After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 575019 - Remove deprecated GTK+ symbols in libeog and libfspot
Remove deprecated GTK+ symbols in libeog and libfspot
Status: RESOLVED FIXED
Product: f-spot
Classification: Other
Component: General
SVN
Other Linux
: Normal normal
: ---
Assigned To: Ruben Vermeersch
F-spot maintainers
Depends on:
Blocks: 585692
 
 
Reported: 2009-03-12 02:02 UTC by André Klapper
Modified: 2009-06-13 23:19 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
patch removing symbols (2.59 KB, patch)
2009-03-28 03:26 UTC, David Mazary 		committed Details | Review

Description André Klapper 2009-03-12 02:02:45 UTC 
http://live.gnome.org/GnomeGoals/RemoveDeprecatedSymbols/GTK%2B

GTK3 (March 2010) will not ship deprecated symbols anymore.

For potential patch contributors, see http://library.gnome.org .

Deprecated symbols:
gdk_pixbuf_render_to_drawable, gdk_pixbuf_render_to_drawable_alpha, gdk_pixbuf_unref, gtk_object_new, gtk_object_sink
Comment 1 David Mazary 2009-03-28 03:26:41 UTC 
Created attachment 131536 [details] [review]
patch removing symbols

I have attached a patch replacing the deprecated GTK+ symbols, except for the gdk_pixbuf_render_to_drawable_alpha call in libeog/image-view.c, since it is within a commented-out block which appears removable.
Comment 2 Ruben Vermeersch 2009-05-11 11:38:40 UTC 
Will review this soonish (ETA: one month). Busy times. Looks good though, only need to test it to see if it works.

If there's anyone that can confirm it's good, it can go in for me.
Comment 3 Ruben Vermeersch 2009-05-11 11:41:33 UTC 
Note that we'll also have to check our C# sources. That should go in another bug though.
Comment 4 Maxxer 2009-05-28 19:26:53 UTC 
tried the patch, everything seems to work fine.

pushed it to gitorious, bgo_575019 branch.
Comment 5 Ruben Vermeersch 2009-05-28 21:20:12 UTC 
Committed:

commit d44d2b7f649d6e31f41c4e720be2b8cf2687a07f
Author: David Mazary <dmaz@vt.edu>
Date:   Thu May 28 21:24:42 2009 +0200

    bgo #575019 – Remove deprecated GTK+ symbols in libeog and libfspot