After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 574998 - lib/engine/protocol/codec-description.h uses strtok
lib/engine/protocol/codec-description.h uses strtok
Status: RESOLVED FIXED
Product: ekiga
Classification: Applications
Component: Engine
GIT master
Other All
: Normal normal
: 3.40
Assigned To: Snark
Ekiga maintainers
Depends on:
Blocks:
 
 
Reported: 2009-03-11 20:52 UTC by Snark
Modified: 2009-03-17 20:29 UTC
See Also:
GNOME target: ---
GNOME version: ---


Description Snark 2009-03-11 20:52:08 UTC 
The documentation says not to use it -- which is already a bad sign.

That code also does a "(char*)foo.c_str ()" to get *write* access to the underlying C string of a std::string -- and strtok effectively modifies it according to its man page.

Using g_strsplit/g_strfreev will be better.

I'll fix it when code freeze will be over.
Comment 1 Eugen Dedu 2009-03-11 21:16:26 UTC 
Changing milestone then (not to forget it).
Comment 2 Snark 2009-03-11 21:30:38 UTC 
Sigh... if we ever go the boost way, then :
http://www.boost.org/doc/libs/1_38_0/doc/html/string_algo/usage.html#id4002194
is probably simpler.