After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 574939 - [typefinding] flac typefinder mis-typefinds PDFs as flac files
[typefinding] flac typefinder mis-typefinds PDFs as flac files
Status: RESOLVED FIXED
Product: GStreamer
Classification: Platform
Component: gst-plugins-base
git master
Other Linux
: Normal normal
: 0.10.23
Assigned To: GStreamer Maintainers
GStreamer Maintainers
Depends on:
Blocks:
 
 
Reported: 2009-03-11 13:43 UTC by Tim-Philipp Müller
Modified: 2009-03-15 20:03 UTC
See Also:
GNOME target: ---
GNOME version: ---


Description Tim-Philipp Müller 2009-03-11 13:43:44 UTC 
The scan-for-a-flac-frame-header part of the flac typefinder seems to be a bit overconfident in its results. I see lots of non-FLAC files typefound as flac, esp. PDFs.

I guess it should look for consecutive headers or something in that case, or lower the probability to something appropriately low (such as POSSIBLE?).

Sample file: http://diracvideo.org/download/specification/diracpro-spec-latest.pdf
Comment 1 Tim-Philipp Müller 2009-03-15 20:03:01 UTC 
commit 04a860c6f7d1d6cc704cb8212457df735fdbbee7
Author: Tim-Philipp Müller <tim.muller@collabora.co.uk>
Date:   Sun Mar 15 19:57:36 2009 +0000

    typefinding: make flac typefinder return lower probability for frame headers
    
    The flac frame header typefinder overstates the likelihood of a match, leading
    to false positives with e.g. aac streams and PDF files. Reduce probabilty
    returned from LIKELY to POSSIBLE for the frame header matchin code.
    Fixes #574939.