After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 574443 - rtsp win32 - forgotten variable
rtsp win32 - forgotten variable
Status: RESOLVED FIXED
Product: GStreamer
Classification: Platform
Component: gst-plugins-base
git master
Other Windows
: Normal trivial
: 0.10.23
Assigned To: Wim Taymans
GStreamer Maintainers
Depends on:
Blocks:
 
 
Reported: 2009-03-07 04:27 UTC by LRN
Modified: 2009-03-08 17:18 UTC
See Also:
GNOME target: ---
GNOME version: ---


Description LRN 2009-03-07 04:27:13 UTC 
You've moved the relevant code to do_connect(), but left the unsigned long flags behind.

diff --git a/gst-libs/gst/rtsp/gstrtspconnection.c b/gst-libs/gst/rtsp/gstrtspconnection.c
index 0cdc6c6..8535dcd 100644
--- a/gst-libs/gst/rtsp/gstrtspconnection.c
+++ b/gst-libs/gst/rtsp/gstrtspconnection.c
@@ -740,9 +740,6 @@ gst_rtsp_connection_connect (GstRTSPConnection * conn, GTimeVal * timeout)
   const gchar *ip;
   guint16 port;
   GstRTSPUrl *url;
-#ifdef G_OS_WIN32
-  unsigned long flags = 1;
-#endif /* G_OS_WIN32 */
 
   g_return_val_if_fail (conn != NULL, GST_RTSP_EINVAL);
   g_return_val_if_fail (conn->url != NULL, GST_RTSP_EINVAL);
Comment 1 Wim Taymans 2009-03-08 17:18:39 UTC 
commit eb3ff95a3aba1306f9621aee83a8a88ee2c05168
Author: LRN <lrn1986@gmail.com>
Date:   Sun Mar 8 18:17:48 2009 +0100

    rtsp: fix compilation on windows.
    
    Remove unused variable when building for windows.
    Fixes #574443.