GNOME Bugzilla – Bug 574174
Remove deprecated libgnomeui dependency
Last modified: 2009-07-18 15:09:40 UTC
http://live.gnome.org/LibgnomeMustDie $:andre\> grep -r gnome.ui . ./colorblind/Utils.py: import gtk, gtk.gdk, gnome.ui, gobject, gnomevfs factory = gnome.ui.ThumbnailFactory(colorblind.ICON_HEIGHT) icon_name, flags = gnome.ui.icon_lookup(ICON_THEME, factory, gnome.ui.ICON_LOOKUP_FLAGS_SHOW_SMALL_IMAGES_AS_THEMSELVES) Note: Similar to bug 573639.
Forwarding comment by mclasen on d-d-l today: "Retrieving of thumbnails is covered in gio/gvfs with the file attributes thumbnail::path thumbnail::failed preview::icon What is not covered is creation of thumbnails, for which we probably have to wait for the outcome of the 'thumbnailing service' ideas that are being floated..."
Willie will hate me for this, but as Bill does not work here anymore...
No hatred. Just an "Eeeks!". :-) Is this a 2.28 or 3.0 deadline?
It does not look that complicated actually. According to Alex Larsson "all the libgnomeui thumbnailer stuff is availible in recent versions of libgnomedesktop." 2.28 definitely prefered. But maybe there's some python volunteers (that also want to take a look at bug 573639)? A call for help on some a11y stuff, e.g. in a blog post, can never hurt, as long as there are people around being able to review contributed patches. ;-)
Now even easier as there's some code to copy from deskbar-applet that just dropped its libgnomeui dependency: http://git.gnome.org/cgit/deskbar-applet/commit/?id=d13a580d9675a9ab58bd365ce8a565b696d11e38 http://git.gnome.org/cgit/deskbar-applet/commit/?id=d1af4f015cb052adf176a1d58230e89fed6f1267 http://git.gnome.org/cgit/deskbar-applet/commit/?id=74d118a88969c9568a398fac6e82b569bfea3375 $:andre\> grep -r "import gnome" . ./colorblind/ui/WindowUI.py: import gnomeapplet ./colorblind/colorblind-applet.py: import gnome ./colorblind/ColorblindApplet.py:import gnomeapplet, gtk, gtk.gdk, gconf, gobject, bonobo, ORBit ./configure.in: import gnomeapplet $:andre\> grep -r "gnome.ui" . ./colorblind/Utils.py: import gtk, gtk.gdk, gnome.ui, gobject ./colorblind/Utils.py: factory = gnome.ui.ThumbnailFactory(colorblind.ICON_HEIGHT) ./colorblind/Utils.py: icon_name, flags = gnome.ui.icon_lookup(ICON_THEME, factory, ./colorblind/Utils.py: gnome.ui.ICON_LOOKUP_FLAGS_SHOW_SMALL_IMAGES_AS_THEMSELVES)
Created attachment 138617 [details] [review] Patch Trivial patch. This *compiles* for me, but I have NOT tested the app itself. Also note that I don't do code. ;-)
Tested on Ubuntu 9.04. Committed to git master. Thanks!