GNOME Bugzilla – Bug 573964
Get rid of deprecated libgnome
Last modified: 2009-05-14 17:10:27 UTC
http://live.gnome.org/LibgnomeMustDie $:andre\> grep -r libgnome . ./Src/Gtk2/dasher_main.cpp: #include <libgnome/libgnome.h> ./Src/main.cc:#include <libgnome/libgnome.h> ./INSTALL.Linux: libgnome2-dev ./configure.in: PKG_CHECK_MODULES(gnome, libgnome-2.0 libgnomeui-2.0 ) ./configure.in: AC_DEFINE([GNOME_LIBS], 1, [libgnome-2 and libgnomeui-2 are present])
According to http://live.gnome.org/GnomeGoals/RemoveGnomeOpenGnomeHelp removing GnomeHelp is just a proposal, and gtk_show_uri is suggested as an alternative, but this only appears in gtk 2.13.1. 2.14 was only released in September 2008, so I don't expect all dasher users to have it: the up-to-date ubuntu 8.04.2 box I'm sitting at only has 2.12.9. The GNOME handbook on writing documentation, http://library.gnome.org/devel/gdp-handbook/stable/buildingdocs.html.en , says use gnome_help_display(). So, it looks to me as though "LibgnomeMustDie" is still an aspiration: the infrastructure for help doesn't seem to be out yet... Comments?
One day I'm going to remove all the "This is a proposal" headers, or even better the wikipages themselves. :-P It's not really a proposal anymore. Getting rid of libgnome(ui) plus a lot of other stuff is a defined goal for GNOME 3. :) Just click on the per-module links to the corresponding bug reports listed in http://live.gnome.org/GnomeGoals/RemoveGnomeOpenGnomeHelp to find some potential patches. And the gdp-handbook is seven years old, see http://library.gnome.org/devel/gdp-handbook/stable/index-info.html.en . I hope that one day the doc team will have enough manpower to provide up-to-date docs - there's recently been some momentum again so I cross my fingers.
I suppose it does give me an excuse to develop on my trusty NetBSD box, as pkgsrc has gtk 2.16.1, but I'll have to leave libgnome cruft in for all those automatically updated cutting edge ubuntu 8.04 LTS boxen - not an insignificant number...
> 2.14 was only released in September 2008, so I don't expect all dasher > users to have it 8.04. That's one year ago. We will even start blocking any bug reports from GNOME 2.22 very soon because one year is a long time in the Linux world and the reports are not really useful - codebases change rapidly. :) So... the questions are: How many distros ship the latest dasher release (4.10.1 from April 2009) as an update to their older distro releases? I don't expect Canonical to push Dasher 4.10.1 for Ubuntu 8.04, same for other distros. How many dasher users install the latest release (4.10.1) themselves on top of the version shipped by default in their distro? I also expect that this number to be very small. The distro concept to me is really about "buying all apps in a kind of box" and not caring about stuff happening/published out there on the internet. This of course only covers Linux. No idea about Windows users here, if Dasher for Windows also requires gtk+ for Windows to be installed - on the other hand users can install a more recent version of gtk+ for windows either. Hence I don't see big issues in raising the dependencies, but that decision is up to the maintainers (you). :)
I'm being silly: cf my own bug #575365
On this front, I have swapped gnome_help_display_desktop to use gtk_show_uri, then had an entertaining time with yelp. Opening ghelp:dasher via gtk_show_uri gives me "Operation not supported". "yelp ghelp:dasher" successfully opens the manual. I also get "Operation not supported" trying to gtk_show_uri "http://www.cam.ac.uk/". In this context, gvfs seems to crop up. dasher is linked with libgio, so what am I missing?
The "Operation not supported" problem happens on a system where: % gconftool-2 -R /desktop/gnome/url-handlers /desktop/gnome/url-handlers/ghelp: enabled = true needs_terminal = false command = gnome-help "%s" ... and gnome-help is a symbolic link to yelp. Any clues on the "Operation not supported"?
Usually that means that gvfs isn't installed.
Created attachment 134338 [details] [review] gnome_help replacement
Does this patch work for you? (Then I'll just assume that my gio wielding system has gvfs deficit...)
Now using gtk_show_uri instead of gnome_help_display_desktop http://git.gnome.org/cgit/dasher/commit/?id=ad877a9128a119e78fe7ec06c0d146a629280db9 So all that is left is gnome_program_init() in Src/main.cc. What is the canonical way of replacing this?
Fixed with http://git.gnome.org/cgit/dasher/commit/?id=5f2dac362cac47bed851acd113636ae3173a961c
Looks like there is still a bit of libgnome stuff left behind: if test x"$WITHA11Y" = xtrue; then PKG_CHECK_MODULES(gnome_a11y, bonobo-activation-2.0 libbonobo-2.0 ORBit-2.0 libgnomeui-2.0 cspi-1.0 atk) AC_DEFINE([GNOME_A11Y], 1, [gnome_a11y libraries are present]) fi or is it intentional?
Well, there are #571750 and #573965 open for bonobo and gnomeui. Now dasher --with-a11y depends on bonobo which depends on gnomeui.
ok. Sorry about the noise here then.