GNOME Bugzilla – Bug 573889
[pitivi] Discoverer: Race in filesink causes some thumbnails to not be generated
Last modified: 2012-10-16 20:16:24 UTC
There's a race in the Discoverer causing some thumbnail files to not be generated. The problem is the following: * We detect a video stream, we add pngenc+filesink to the file sink * We wait for the pipeline to change state to PAUSED (i.e. prerolled) * This happens when the encoded buffer arrives in the filesink BUT is not processed (it's waiting) * In the bus message handler we set the state to PLAYING => RACE between the moment the prerolled buffer is handled (passed on to filesink_render) and the EOS coming in from pngenc in snapshot mode.
Wondering if that's still the case nowadays. Well, we do have all sorts of fun races like bug #681015, still.
I'm not sure this analysis ever made sense. It would've made sense if pngenc had ever posted an EOS message directly (instead of sending an eos event downstream and/or returning FLOW_UNEXPECTED to make upstream push an eos event downstream), but I can't find any trace of that going back as far as 2006. I would suggest we close this as OBSOLETE and handle specific bugs (e.g. with debug logs) in other reports. Also, is it possible this was a different discoverer than the one in pbutils, namely the gst-python discoverer?
Closing as per last comment.