GNOME Bugzilla – Bug 573375
Last modified: 2009-04-09 23:17:59 UTC
Instead of the current hard-coded interface
Created attachment 129929 [details] [review]
GtkBuilder UI for Gnome Bluetooth Wizard
- .glade file generated in Glade 3
- .ui file generated from .glade file using gtk-builder-convert
- Modifications to wizard/main.c to use the GtkBuilder file
- What to do if the file fails to load
- The UI file is loaded from the current directory
- The UI file is not installed
- There is a bug in the passcode dialog. Open it an click on the any radio button - the dialog closes. It doesn't seem to be calling any callback when the currently selected one is clicked and I can't see why this is closing the dialog.
I probably wont get around to finishing the patch so someone else please continue this work.
Additionally the standard UI problem of the bold labels marked for translation with markup.
You forgot to mark those signal handlers as non-static (ie. remove the static keyword in front of the function, and declare them at the top of the file).
I tried that but it still didn't work. I'm guessing it needs to be linked against gmodule/have the correct compiler flags as in:
The passcode dialog but is that the radio buttons have a response ID. If you manually edit the .ui file and remove response="0" for the radio buttons it works fine. There doesn't seem to be a way for Glade to specify no response ID so this may be a Glade bug.
Could you please update your patch? It doesn't apply against trunk anymore.
I'll try to fix it up afterwards.
Created attachment 131490 [details] [review]
Rebuilt patch and corrected .ui file
Rebuilt against head and the .ui file is fixed by passing it through Glade 2.6.0.
Had to make quite a few changes, as you were using the old UI for the passkey dialogue, and the Close button was getting disabled even when the custom entry wasn't selected.
I also killed a few unused widgets, and hid the passkey label by default. Hopefully it still works alright.
Fixed in trunk:
Reopening, we obviously need to use the signal handlers in the GtkBuilder file.
All done in trunk.