After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 573292 - Remove deprecated GTK+ symbols
Remove deprecated GTK+ symbols
Product: gnome-utils
Classification: Deprecated
Component: general
Other Linux
: Normal normal
: ---
Assigned To: gnome-utils Maintainers
gnome-utils Maintainers
Depends on:
Blocks: 585692
Reported: 2009-02-26 16:54 UTC by André Klapper
Modified: 2010-05-28 10:42 UTC
See Also:
GNOME target: 3.0
GNOME version: 2.29/2.30

use gtk_editable_set_editable (608 bytes, patch)
2009-02-26 17:22 UTC, Thomas Andersen
committed Details | Review
Replace deprecated symbols. Port to GtkSpinner (34.51 KB, patch)
2010-05-08 15:01 UTC, Thomas Andersen
none Details | Review

Description André Klapper 2009-02-26 16:54:40 UTC

(Is gfloppy alive at all? If not, are there plans to remove it?)

========= GNOME-DICTIONARY =========
$:andre\> grep -r gtk_entry_set_editable .
./gnome-dictionary/src/gdict-applet.c:  gtk_entry_set_editable (GTK_ENTRY (priv->entry), TRUE);

========= GFLOPPY =========
$:andre\> grep -r GTK_SIGNAL_FUNC .
./gfloppy/src/main.c: gtk_signal_connect (GTK_OBJECT (menu_item), "activate", GTK_SIGNAL_FUNC (devices_option_activated), list->data);
./gfloppy/src/progress.c: gtk_signal_connect (GTK_OBJECT (progress_dialog), "response", GTK_SIGNAL_FUNC (progress_response_callback), floppy);

$:andre\> grep -r gdk_input_add .
./gfloppy/src/progress.c: floppy->handler_id = gdk_input_add (floppy->message[0], GDK_INPUT_READ, read_stdinput, floppy);

$:andre\> grep -r gdk_input_remove .
./gfloppy/src/progress.c: gdk_input_remove (floppy->handler_id);

$:andre\> grep -r gtk_menu_append .
./gfloppy/src/main.c:	gtk_menu_append (GTK_MENU (menu), menu_item);

$:andre\> grep -r gtk_option_menu_get_history .
./gfloppy/src/main.c:	cannot_check = gtk_option_menu_get_history (type_om) == 1 && /* fat fs */
./gfloppy/src/main.c:	floppy.type = gtk_option_menu_get_history (GTK_OPTION_MENU (type_option)); /* user choice */
./gfloppy/src/main.c:	floppy.size = gtk_option_menu_get_history (GTK_OPTION_MENU (density_option));
./gfloppy/src/main.c:	switch (gtk_option_menu_get_history (GTK_OPTION_MENU (type_option))) {

$:andre\> grep -r gtk_option_menu_get_menu .
./gfloppy/src/main.c:	menu = gtk_option_menu_get_menu (GTK_OPTION_MENU (type_option));

$:andre\> grep -r gtk_option_menu_remove_menu .
./gfloppy/src/main.c:	gtk_option_menu_remove_menu (GTK_OPTION_MENU (device_option));

$:andre\> grep -r gtk_option_menu_set_history .
./gfloppy/src/main.c:	gtk_option_menu_set_history (GTK_OPTION_MENU (device_option), 0);
./gfloppy/src/main.c:	gtk_option_menu_set_history (GTK_OPTION_MENU (type_option), GFLOPPY_FAT);
./gfloppy/src/main.c:	gtk_option_menu_set_history (GTK_OPTION_MENU (type_option), GFLOPPY_E2FS);
./gfloppy/src/main.c:	gtk_option_menu_set_history (GTK_OPTION_MENU (type_option), floppy.mke2fs_cmd ? 1 : 0);

$:andre\> grep -r gtk_option_menu_set_menu .
./gfloppy/src/main.c:	gtk_option_menu_set_menu (GTK_OPTION_MENU (device_option), menu);

$:andre\> grep -r gtk_progress_bar_update .
./gfloppy/src/progress.c:	gtk_progress_bar_update (GTK_PROGRESS_BAR (progressbar),

$:andre\> grep -r gtk_signal_connect .
./gfloppy/src/main.c:	gtk_signal_connect (GTK_OBJECT (menu_item), "activate", GTK_SIGNAL_FUNC (devices_option_activated), list->data);
./gfloppy/src/progress.c: gtk_signal_connect (GTK_OBJECT (progress_dialog), "response", GTK_SIGNAL_FUNC (progress_response_callback), floppy);
Comment 1 Thomas Andersen 2009-02-26 17:22:08 UTC
Created attachment 129584 [details] [review]
use gtk_editable_set_editable

trivial patch for src/gdict-applet.c
Comment 2 Cosimo Cecchi 2009-02-27 13:33:26 UTC
Please commit.
Comment 3 Thomas Andersen 2009-03-02 00:23:50 UTC
Commited as r8448:

gfloppy stuff still remaining unless it is going to be removed.
Comment 4 Thomas Andersen 2009-04-21 21:06:03 UTC
do you still want to keep this bug open now that gfloppy is gone?
Comment 5 Cosimo Cecchi 2009-04-21 21:27:12 UTC
No, there's no point in keeping this opened.
Comment 6 André Klapper 2010-04-12 16:59:45 UTC

$:andre\> grep -r GTK_WIDGET_NO_WINDOW .
     if (GTK_WIDGET_NO_WINDOW (align_widget))
     if (GTK_WIDGET_STATE (drawing_area) != GTK_STATE_NORMAL)
     GTK_WIDGET_STATE (drawing_area),
Comment 7 Thomas Andersen 2010-05-08 15:01:25 UTC
Created attachment 160578 [details] [review]
Replace deprecated symbols. Port to GtkSpinner

Built on top of my GSEAL patch for bug #612485. That one might have to be committed first.

Also ports gsearchtool to use GtkSpinner.
Comment 8 Cosimo Cecchi 2010-05-27 23:17:12 UTC
Thanks for the patch. I split it into single commits and pushed it to master.

In the future, please try to split such horizontal changes into separate commits, as that makes it easier to review them.
Comment 9 André Klapper 2010-05-28 10:42:58 UTC
Cosimo: Big Thanks, as always!