After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 573283 - Most options should be disabled when right clicking on in a chatroom
Most options should be disabled when right clicking on in a chatroom
Status: RESOLVED FIXED
Product: empathy
Classification: Core
Component: Chat
2.25.x
Other Linux
: Normal normal
: ---
Assigned To: empathy-maint
Depends on:
Blocks:
 
 
Reported: 2009-02-26 15:23 UTC by Guillaume Desmottes
Modified: 2010-10-25 12:34 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
proposed fix (2.79 KB, patch)
2010-10-22 17:02 UTC, Vitaly Minko 		reviewed Details | Review

Description Guillaume Desmottes 2009-02-26 15:23:30 UTC 
- Join a chatroom
- Right click on yourself
- You can open a chat, send a file and send an invite to yourself!

These options should be disabled.
Comment 1 Vitaly Minko 2010-10-22 17:00:37 UTC 
Fixed in
repo: git://vminko.org/empathy
branch: fix-573283
Comment 2 Vitaly Minko 2010-10-22 17:02:44 UTC 
Created attachment 173021 [details] [review]
proposed fix
Comment 3 Guillaume Desmottes 2010-10-25 09:35:13 UTC 
Review of attachment 173021 [details] [review]:

Looks good, small style issues to fix though.

::: libempathy-gtk/empathy-contact-menu.c
@@ +232,3 @@
 					      GTK_ICON_SIZE_MENU);
 	gtk_image_menu_item_set_image (GTK_IMAGE_MENU_ITEM (item), image);
+	gtk_widget_set_sensitive (item, !empathy_contact_is_user(contact));

should be empathy_contact_is_user (contact).
Same above.
Comment 4 Vitaly Minko 2010-10-25 10:12:35 UTC 
Fixed in the same branch.
Comment 5 Guillaume Desmottes 2010-10-25 12:34:01 UTC 
Merged to master; thanks!

This problem has been fixed in the development version. The fix will be available in the next major software release. Thank you for your bug report.