GNOME Bugzilla – Bug 572333
Remove deprecated GTK+ symbols
Last modified: 2010-02-09 14:01:53 UTC
GTK_SIGNAL_FUNC, GdkDestroyNotify, GtkDestroyNotify, GtkType, gdk_image_get, gdk_window_get_size, gtk_combo_new, gtk_combo_set_popdown_strings, gtk_combo_set_value_in_list, gtk_menu_append, gtk_object_sink, gtk_option_menu_get_menu, gtk_option_menu_new, gtk_option_menu_set_menu, gtk_signal_disconnect_by_data, gtk_tool_item_set_tooltip, gtk_toolbar_set_orientation, gtk_tooltips_new, gtk_type_class, gtk_widget_get_action, gtk_widget_ref, gtk_widget_unref
For potential patch contributors:
It might make sense to break this into several smaller patches. :-P
Some stuff is really only about replacing a string, some is much more complex.
Also make sure that the gtk and glib versions in configure.in are high enough
and take a look since which version the new non-deprecated functions are
available. http://library.gnome.org is your friend. :-)
Also see bug 439667.
There is really not much to be done here. All the currently deprecated stuff is in code copied in from ggz. This will be replaced with new code for 2.27 once ggz reaches 1.0 that does not have this problem.
Other than that there are 2 places with GTK symbols that was deprecated in 2.16. Fixing these will require bumping minimum GTK to 2.16 and we will wait with this until after we branch 2.26.
So the conclusion is that there really is nothing to do here other than waiting :)
Created attachment 132248 [details] [review]
Replace gtk_toolbar_set_orientation in gtali
The two non-ggz cases of deprecated GTK symbols are:
gtali/gyahtzee.c:824: gtk_toolbar_set_orientation (GTK_TOOLBAR (toolbar),
libgames-support/games-stock.c:94: action = gtk_widget_get_action (widget);
This patch fixes the gtali case and bumps the required gtk version to 2.16.
games-stock.c is already ifdef'ed.
Is there a public ggz release schedule, or is it "it's available when it's ready"? I see that 0.99.5 has been made available in January 2009.
Last thing I heard they were planning to get it out for fedora 11. But it is a long time ago that they told me that.
Can you contact them again? (I can do that too of course.)
107.4% of software projects tend to take longer than expected because something is buggy, just like the percentage calculation in this scripted comment.
The bug tracking this issue upstream at ggz is:
Patches are committed to ggz SVN trunk in r10939.
See the tracker bug above for more info and http://svn.ggzgamingzone.org/trac.cgi/changeset/10939/trunk/gtk-client
I currently don't see this happening for 2.28, hence moving gnome-target to 2.30 must have.
fixed in master
http://www.gnome.org/~fpeters/reports/299.html still displays as "To Do" in aisleriot/prop-editor.c:
gtk_option_menu_get_history, gtk_option_menu_new, gtk_option_menu_set_history, gtk_option_menu_set_menu .
Are they real issues and this should be reopened? Or is that not used and I should whitelist it for 299.html?
prop-editor.[ch] is copied from gtk+/tests/prop-editor.[ch]. So get it fixed in gtk+, and we'll re-import it :)
Reopening and adding dependency ;)
chpe: Fixed now in gtk+, want to reimport it now?