After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 572333 - Remove deprecated GTK+ symbols
Remove deprecated GTK+ symbols
Product: gnome-games-superseded
Classification: Deprecated
Component: general
Other All
: Normal normal
: ---
Assigned To: gnome-games-general-maint
GNOME Games maintainers
Depends on: 606288
Blocks: 585692
Reported: 2009-02-18 22:16 UTC by André Klapper
Modified: 2010-02-09 14:01 UTC
See Also:
GNOME target: 2.30.x
GNOME version: ---

Replace gtk_toolbar_set_orientation in gtali (861 bytes, patch)
2009-04-07 09:04 UTC, Thomas Andersen
committed Details | Review

Description André Klapper 2009-02-18 22:16:48 UTC

GTK_SIGNAL_FUNC, GdkDestroyNotify, GtkDestroyNotify, GtkType, gdk_image_get, gdk_window_get_size, gtk_combo_new, gtk_combo_set_popdown_strings, gtk_combo_set_value_in_list, gtk_menu_append, gtk_object_sink, gtk_option_menu_get_menu, gtk_option_menu_new, gtk_option_menu_set_menu, gtk_signal_disconnect_by_data, gtk_tool_item_set_tooltip, gtk_toolbar_set_orientation, gtk_tooltips_new, gtk_type_class, gtk_widget_get_action, gtk_widget_ref, gtk_widget_unref

For potential patch contributors:
It might make sense to break this into several smaller patches. :-P
Some stuff is really only about replacing a string, some is much more complex.
Also make sure that the gtk and glib versions in are high enough
and take a look since which version the new non-deprecated functions are
available. is your friend. :-)

Also see bug 439667.
Comment 1 Thomas Andersen 2009-02-18 23:14:03 UTC
There is really not much to be done here. All the currently deprecated stuff is in code copied in from ggz. This will be replaced with new code for 2.27 once ggz reaches 1.0 that does not have this problem.

Other than that there are 2 places with GTK symbols that was deprecated in 2.16. Fixing these will require bumping minimum GTK to 2.16 and we will wait with this until after we branch 2.26.

So the conclusion is that there really is nothing to do here other than waiting :)
Comment 2 Thomas Andersen 2009-04-07 09:04:32 UTC
Created attachment 132248 [details] [review]
Replace gtk_toolbar_set_orientation in gtali

The two non-ggz cases of deprecated GTK symbols are:
gtali/gyahtzee.c:824:  gtk_toolbar_set_orientation (GTK_TOOLBAR (toolbar),
libgames-support/games-stock.c:94:  action = gtk_widget_get_action (widget);

This patch fixes the gtali case and bumps the required gtk version to 2.16.

games-stock.c is already ifdef'ed.
Comment 3 André Klapper 2009-04-09 08:45:05 UTC
Is there a public ggz release schedule, or is it "it's available when it's ready"? I see that 0.99.5 has been made available in January 2009.
Comment 4 Thomas Andersen 2009-04-09 09:03:14 UTC
Last thing I heard they were planning to get it out for fedora 11. But it is a long time ago that they told me that. 
Comment 5 André Klapper 2009-04-09 09:16:22 UTC
Can you contact them again? (I can do that too of course.)
107.4% of software projects tend to take longer than expected because something is buggy, just like the percentage calculation in this scripted comment.
Comment 6 Thomas Andersen 2009-05-03 23:05:22 UTC
The bug tracking this issue upstream at ggz is:

Comment 7 Javier Jardón (IRC: jjardon) 2009-07-14 01:42:01 UTC
Patches are committed to ggz SVN trunk in r10939.
See the tracker bug above for more info and
Comment 8 André Klapper 2009-08-17 10:44:59 UTC
I currently don't see this happening for 2.28, hence moving gnome-target to 2.30 must have.
Comment 9 Thomas Andersen 2009-10-15 23:04:05 UTC
fixed in master
Comment 10 André Klapper 2010-01-06 16:38:05 UTC still displays as "To Do" in aisleriot/prop-editor.c:
gtk_option_menu_get_history, gtk_option_menu_new, gtk_option_menu_set_history, gtk_option_menu_set_menu .

Are they real issues and this should be reopened? Or is that not used and I should whitelist it for 299.html?
Comment 11 Christian Persch 2010-01-06 17:09:35 UTC
prop-editor.[ch] is copied from gtk+/tests/prop-editor.[ch]. So get it fixed in gtk+, and we'll re-import it :)
Comment 12 Javier Jardón (IRC: jjardon) 2010-01-07 07:08:27 UTC
Reopening and adding dependency ;)
Comment 13 André Klapper 2010-02-09 13:47:29 UTC
chpe: Fixed now in gtk+, want to reimport it now?
Comment 14 Christian Persch 2010-02-09 14:01:53 UTC