After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 572239 - Remove deprecated GTK+ symbols
Remove deprecated GTK+ symbols
Status: RESOLVED FIXED
Product: xchat-gnome
Classification: Other
Component: general
HEAD
Other Linux
: Normal normal
: ---
Assigned To: xchat-gnome maintainers
xchat-gnome maintainers
Depends on: 572273
Blocks: 585692
 
 
Reported: 2009-02-18 04:23 UTC by André Klapper
Modified: 2009-06-13 23:19 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
proposed patch (1.71 KB, patch)
2009-04-21 15:48 UTC, Pedro Fragoso 		committed Details | Review

Description André Klapper 2009-02-18 04:23:46 UTC 
http://live.gnome.org/GnomeGoals/RemoveDeprecatedSymbols/GTK%2B



http://library.gnome.org/devel/gdk/stable/gdk-Images.html#gdk-image-get

./src/fe-gnome/xtext.c:
     img = gdk_image_get (GTK_WIDGET (xtext)->window, 0, 0, width+128, height);



http://library.gnome.org/devel/gdk/stable/gdk-Windows.html#gdk-window-get-size

./src/fe-gnome/xtext.c:
     gdk_window_get_size (GTK_WIDGET (xtext)->window, &width, &height);



http://library.gnome.org/devel/gtk/unstable/gtk-Signals.html#gtk-signal-disconnect-by-data

./src/fe-gnome/xtext.c:
     /* gtk_signal_disconnect_by_data (GTK_OBJECT (xtext->adj), xtext);*/
Comment 1 André Klapper 2009-02-18 11:25:56 UTC 
These are just deprecated in gtk 2.14.
There are more deprecations in gtk 2.15, hence xchat must also get rid of
gtk_action_connect_proxy, gtk_status_icon_set_tooltip .
Comment 2 Javier Jardón (IRC: jjardon) 2009-04-21 01:27:15 UTC 
I can compile the latest version from git without errors with these options:

make CFLAGS+="-DGDK_PIXBUF_DISABLE_DEPRECATED -DGDK_DISABLE_DEPRECATED -DGTK_DISABLE_DEPRECATED -DG_DISABLE_DEPRECATED"
Comment 3 Pedro Fragoso 2009-04-21 15:48:13 UTC 
Created attachment 133050 [details] [review]
proposed patch
Comment 4 Christian Persch 2009-04-21 15:55:08 UTC 
Thanks; please commit to master.
Comment 5 Pedro Fragoso 2009-04-21 15:57:12 UTC 
@chpe: I don't have commit rights.

Someone feel free to commit this.

Thanks.
Comment 6 Baptiste Mille-Mathias 2009-05-31 12:06:42 UTC 
hello, 

I commited the fix, Christian I hope you don't mind.
Thanks Pedro

Cheers.