After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 572084 - Remove deprecated GTK+ symbols
Remove deprecated GTK+ symbols
Product: librsvg
Classification: Core
Component: general
Other Linux
: Normal normal
: ---
Assigned To: librsvg maintainers
librsvg maintainers
Depends on:
Blocks: 585692
Reported: 2009-02-16 23:15 UTC by André Klapper
Modified: 2009-07-18 13:13 UTC
See Also:
GNOME target: ---
GNOME version: ---

patch (3.15 KB, patch)
2009-02-24 12:02 UTC, André Klapper
committed Details | Review
Remove gdk_draw_string deprecated symbol (1.57 KB, patch)
2009-07-12 18:46 UTC, Javier Jardón (IRC: jjardon)
committed Details | Review

Description André Klapper 2009-02-16 23:15:46 UTC
See .

GtkStyle::font_desc field could be used instead, see

./gtk-engine/svg-draw.c:      gdk_draw_string(window, gtk_style_get_font (style), style->fg_gc[state], x, y, string);
./gtk-engine/svg-draw.c:      gdk_draw_string(window, gtk_style_get_font (style), style->fg_gc[state], x, y, string);
Comment 1 André Klapper 2009-02-18 11:32:15 UTC
These were just deprecations for gtk 2.14.

There are more deprecations for gtk 2.15, hence librsvg must also get rid of
gdk_draw_string, gdk_gc_unref, gdk_pixbuf_render_to_drawable, gdk_pixbuf_render_to_drawable_alpha, gdk_pixbuf_unref, gdk_pixmap_unref, gdk_window_get_size
Comment 2 Dominic Lachowicz 2009-02-19 23:24:39 UTC
Patches welcomed.
Comment 3 André Klapper 2009-02-24 12:02:55 UTC
Created attachment 129403 [details] [review]

Should fix all but gdk_draw_string(). Double-check because I'm quite bad in writing code. But it does compile. ;-)
Comment 4 André Klapper 2009-03-02 01:34:46 UTC
Comment 5 Dominic Lachowicz 2009-03-02 04:03:25 UTC
“The two most powerful warriors are patience and time.”
Comment 6 André Klapper 2009-03-02 04:10:48 UTC
Not in my business. ;-)
Comment 7 André Klapper 2009-04-14 17:59:12 UTC
Define patience by an amount of weeks/months? ;-)
Comment 8 André Klapper 2009-05-04 10:38:55 UTC
OK, if this does not get a review within the next two weeks, I am going to consider this module deprecated and just commit.
Comment 9 Thomas Andersen 2009-05-13 22:30:37 UTC
The patch looks good to me
Comment 10 André Klapper 2009-05-14 14:53:21 UTC
Thanks for the review.

Seems I should also increase the dep in's
     PKG_CHECK_MODULES(GTK, gtk+-2.0 >= 2.6.0, have_gtk=yes,
from 2.6.0 to 2.16.0 when committing this soon.
Comment 11 André Klapper 2009-05-27 21:05:29 UTC
Seems like I've just branched librsvg for gnome-2-26, hence this could get in now.
Comment 12 André Klapper 2009-06-01 12:24:40 UTC
Patch committed to master: d8b0dc125c41f6017e19a81dd3f92397c8a6e0be
No idea if "gdk-x11-2.0 >= 2.0.0" in also needed a bump.
Probably not.

gdk_draw_string() still missing hence not closing the ticket.
Comment 13 André Klapper 2009-06-01 12:33:45 UTC
Err, well, wrong.
I've also removed gdk_pixmap_unref() in fd58ea90f77e373aeafe48117386ac0dada00148.

Hence still to do: gdk_draw_string, gtk_style_get_font
Comment 14 Javier Jardón (IRC: jjardon) 2009-07-12 18:46:15 UTC
Created attachment 138294 [details] [review]
Remove gdk_draw_string deprecated symbol
Comment 15 Javier Jardón (IRC: jjardon) 2009-07-12 18:47:42 UTC
Remove gtk_style_get_font symbol is not necessary because It's in Changelog file
Comment 16 Thomas Andersen 2009-07-13 18:50:18 UTC
The patch looks good to me.
Comment 17 André Klapper 2009-07-18 13:13:33 UTC
Committed to master:

Thanks Javier & Thomas!

Closing as FIXED.