GNOME Bugzilla – Bug 572084
Remove deprecated GTK+ symbols
Last modified: 2009-07-18 13:13:33 UTC
See http://library.gnome.org/devel/gtk/stable/GtkStyle.html#gtk-style-get-font . GtkStyle::font_desc field could be used instead, see http://developer.gnome.org/doc/API/2.0/gtk/GtkStyle.html#GtkStyle-struct ./gtk-engine/svg-draw.c: gdk_draw_string(window, gtk_style_get_font (style), style->fg_gc[state], x, y, string); ./gtk-engine/svg-draw.c: gdk_draw_string(window, gtk_style_get_font (style), style->fg_gc[state], x, y, string);
These were just deprecations for gtk 2.14. There are more deprecations for gtk 2.15, hence librsvg must also get rid of gdk_draw_string, gdk_gc_unref, gdk_pixbuf_render_to_drawable, gdk_pixbuf_render_to_drawable_alpha, gdk_pixbuf_unref, gdk_pixmap_unref, gdk_window_get_size
Patches welcomed.
Created attachment 129403 [details] [review] patch Should fix all but gdk_draw_string(). Double-check because I'm quite bad in writing code. But it does compile. ;-)
ping
“The two most powerful warriors are patience and time.”
Not in my business. ;-) NP
Define patience by an amount of weeks/months? ;-)
OK, if this does not get a review within the next two weeks, I am going to consider this module deprecated and just commit.
The patch looks good to me
Thanks for the review. Seems I should also increase the dep in configure.in's have_gtk=no PKG_CHECK_MODULES(GTK, gtk+-2.0 >= 2.6.0, have_gtk=yes, have_gtk=no) from 2.6.0 to 2.16.0 when committing this soon.
Seems like I've just branched librsvg for gnome-2-26, hence this could get in now.
Patch committed to master: d8b0dc125c41f6017e19a81dd3f92397c8a6e0be No idea if "gdk-x11-2.0 >= 2.0.0" in configure.in also needed a bump. Probably not. gdk_draw_string() still missing hence not closing the ticket.
Err, well, wrong. I've also removed gdk_pixmap_unref() in fd58ea90f77e373aeafe48117386ac0dada00148. Hence still to do: gdk_draw_string, gtk_style_get_font
Created attachment 138294 [details] [review] Remove gdk_draw_string deprecated symbol
Remove gtk_style_get_font symbol is not necessary because It's in Changelog file
The patch looks good to me.
Committed to master: http://git.gnome.org/cgit/librsvg/commit/?id=248b73101710f01711d4da885fb907082a4709e5 Thanks Javier & Thomas! Closing as FIXED.