After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 571876 - Get rid of deprecated Bonobo
Get rid of deprecated Bonobo
Status: RESOLVED FIXED
Product: empathy
Classification: Core
Component: General
2.25.x
Other Linux
: Normal normal
: ---
Assigned To: empathy-maint
empathy-maint
Depends on: 572131
Blocks: 588321
 
 
Reported: 2009-02-15 20:10 UTC by André Klapper
Modified: 2009-10-20 13:06 UTC
See Also:
GNOME target: ---
GNOME version: ---


Attachments
remove useless bonobo includes (812 bytes, patch)
2009-02-15 21:05 UTC, Frederic Peters
rejected Details | Review

Description André Klapper 2009-02-15 20:10:26 UTC
libbonobo and libbonoboui are deprecated as per
http://live.gnome.org/TwoPointTwentyfive/Platform and hence the dependency
should be completely removed.

See for example http://www.ibm.com/developerworks/linux/library/l-dbus.html or
http://www.mail-archive.com/gnome-devel-list@gnome.org/msg00997.html .


./empathy/megaphone/src/megaphone-applet.c:
         #include <bonobo/bonobo-ui-component.h>
./empathy/nothere/src/nothere-applet.c:
         #include <bonobo/bonobo-ui-component.h>
Comment 1 Frederic Peters 2009-02-15 21:05:45 UTC
Created attachment 128794 [details] [review]
remove useless bonobo includes

Actually those include lines are not necessary; as no symbol from bonobo is referenced in the source files.

This will "fix" this bug, but the libbonobo dependency will still be there as long as the panel applets require it.
Comment 2 Guillaume Desmottes 2009-02-16 10:16:54 UTC
Are you sure it's safe to remove it?

$ git-grep -i bonobo
megaphone/data/GNOME_Megaphone_Applet.server.in.in:                <item value="IDL:Bonobo/GenericFactory:1.0"/>
megaphone/data/GNOME_Megaphone_Applet.server.in.in:                <item value="IDL:Bonobo/Unknown:1.0"/>
megaphone/data/GNOME_Megaphone_Applet.server.in.in:                <item value="IDL:Bonobo/Control:1.0"/>
megaphone/data/GNOME_Megaphone_Applet.server.in.in:                <item value="IDL:Bonobo/Unknown:1.0"/>
megaphone/data/Makefile.am:# Panel applet bonobo stuff
megaphone/data/Makefile.am:serverdir = $(libdir)/bonobo/servers
megaphone/src/megaphone-applet.c:#include <bonobo/bonobo-ui-component.h>
megaphone/src/megaphone-applet.c:static void megaphone_applet_information_cb            (BonoboUIComponent  *uic,
megaphone/src/megaphone-applet.c:static void megaphone_applet_preferences_cb            (BonoboUIComponent  *uic,
megaphone/src/megaphone-applet.c:static void megaphone_applet_about_cb                  (BonoboUIComponent  *uic,
megaphone/src/megaphone-applet.c:static const BonoboUIVerb megaphone_applet_menu_verbs [] = {
megaphone/src/megaphone-applet.c:       BONOBO_UI_UNSAFE_VERB ("information", megaphone_applet_information_cb),
megaphone/src/megaphone-applet.c:       BONOBO_UI_UNSAFE_VERB ("preferences", megaphone_applet_preferences_cb),
megaphone/src/megaphone-applet.c:       BONOBO_UI_UNSAFE_VERB ("about",       megaphone_applet_about_cb),
megaphone/src/megaphone-applet.c:       BONOBO_UI_VERB_END
megaphone/src/megaphone-applet.c:megaphone_applet_information_cb (BonoboUIComponent *uic,
megaphone/src/megaphone-applet.c:megaphone_applet_preferences_cb (BonoboUIComponent *uic, 
megaphone/src/megaphone-applet.c:megaphone_applet_about_cb (BonoboUIComponent *uic, 
megaphone/src/megaphone-applet.c:PANEL_APPLET_BONOBO_FACTORY ("OAFIID:GNOME_Megaphone_Applet_Factory",
nothere/data/GNOME_NotHere_Applet.server.in.in:                <item value="IDL:Bonobo/GenericFactory:1.0"/>
nothere/data/GNOME_NotHere_Applet.server.in.in:                <item value="IDL:Bonobo/Unknown:1.0"/>
nothere/data/GNOME_NotHere_Applet.server.in.in:                <item value="IDL:Bonobo/Control:1.0"/>
nothere/data/GNOME_NotHere_Applet.server.in.in:                <item value="IDL:Bonobo/Unknown:1.0"/>
nothere/data/Makefile.am:# Panel applet bonobo stuff
nothere/data/Makefile.am:serverdir = $(libdir)/bonobo/servers
nothere/src/nothere-applet.c:#include <bonobo/bonobo-ui-component.h>
nothere/src/nothere-applet.c:static void nothere_applet_about_cb (BonoboUIComponent *uic,
nothere/src/nothere-applet.c:static const BonoboUIVerb nothere_applet_menu_verbs [] = {
nothere/src/nothere-applet.c:   BONOBO_UI_UNSAFE_VERB ("about", nothere_applet_about_cb),
nothere/src/nothere-applet.c:   BONOBO_UI_VERB_END
nothere/src/nothere-applet.c:nothere_applet_about_cb (BonoboUIComponent *uic, 
nothere/src/nothere-applet.c:PANEL_APPLET_BONOBO_FACTORY ("OAFIID:GNOME_NotHere_Applet_Factory",
Comment 3 Frederic Peters 2009-02-16 10:18:43 UTC
Yes, it will get there via panel-applet.h
Comment 4 Xavier Claessens 2009-02-16 10:36:58 UTC
We are using directly API from bonobo/bonobo-ui-component.h, not only through panel-applet.h, so I think we should keep that header.

I suggest closing this bug as WONTFIX. Megaphone is an optional part of empathy and there is nothing we can really do until gnome-panel get rid of bonobo.
Comment 5 Guillaume Desmottes 2009-02-16 10:41:56 UTC
No, this bug should stay open a depend on the similar bug in gnome-panel.
Comment 6 André Klapper 2009-02-17 11:34:56 UTC
gnome-panel bug: bug 572131.
Comment 7 Guillaume Desmottes 2009-10-20 13:06:14 UTC
We just dropped the applets (bug #599042) so this bug can be closed.