GNOME Bugzilla – Bug 571846
user password may end up in /var/log/messages
Last modified: 2010-07-02 18:59:13 UTC
Hi. I use x11vnc on my GNOME workstation so that I can access it the same way I would if I were in front of it. Today, I typed my password at GDM login prompt but somehow, an extra character ended-up in my password box and the following appeared in /var/log/messages: Feb 15 16:14:54 foostation gdmlogin[20771]: WARNING: string not in proper utf8 encoding: "pwd@\M-C\240@\M-C\240" In this case my password was "pwd@@". This is a major security concern especially since /var/log/messages is readable by anyone! This is under OpenBSD with GNOME-2.24.3 and GDM-2.20.9. I mentioned x11vnc because I think it was the reason I was able to insert a non proper encoding. For now, I'm just using this to make sure my password does not end up in the logs... --- common/gdm-common.c.orig Sun Feb 15 16:49:17 2009 +++ common/gdm-common.c Sun Feb 15 16:49:58 2009 @@ -230,7 +230,7 @@ ve_locale_from_utf8 (const char *str) char *ret = g_locale_from_utf8 (str, -1, NULL, NULL, NULL); if (ret == NULL) { - g_warning ("string not in proper utf8 encoding: \"%s\"", str); + g_warning ("string not in proper utf8 encoding"); return g_strdup (str); } else { return ret;
I can confirm this (security) issue, and the proposed patch was also committed into OpenBSD ports, fwiw.
Created attachment 161016 [details] [review] updated patch Actually I would recommend using this patch. Note that ve-misc.c has 4 places where it can print out strings that are not in the proper encoding. It is probably safest to just remove them all, especially since I don't think that the debug messages really add that much value anyway.
I am all for it. I've been running with my own patch for more than a year now and I haven't found any situation where I would miss the strings prints. Thanks for finally looking into this.
Hi Brian. Any news regarding this?
What news are you expecting? Do you think there should be another GDM 2.20.x release with this patch?
Sure. Unless this bug is supposed to stay open forever. IIRC version > 2.20.x requires the kit stuffs (consolekit, policykit) so updating is a no go.
Committed to 2.20 branch.