After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 571799 - (ARIA) Need to clean up braille presentation of certain widgets
(ARIA) Need to clean up braille presentation of certain widgets
Status: RESOLVED FIXED
Product: orca
Classification: Applications
Component: braille
2.25.x
Other All
: Normal normal
: ---
Assigned To: Joanmarie Diggs (IRC: joanie)
Orca Maintainers
Depends on:
Blocks: 404403
 
 
Reported: 2009-02-15 01:53 UTC by Joanmarie Diggs (IRC: joanie)
Modified: 2009-02-24 21:39 UTC
See Also:
GNOME target: ---
GNOME version: 2.23/2.24

Attachments
fix for the issues in the opening report (56.27 KB, patch)
2009-02-15 02:07 UTC, Joanmarie Diggs (IRC: joanie) 		committed Details | Review

Description Joanmarie Diggs (IRC: joanie) 2009-02-15 01:53:14 UTC 
Our braille presentation of certain ARIA widgets needs to be improved. In particular:

1. Correct display of page tabs (i.e. present full line, set visible to begin with current tab for the purpose of orientation as well as cursor routing).

2. Only display the slider when a slider is focused.

3. Lose the bogus EOL indicators we see for paragraphs and other non-editable, non-focusable text objects.

I'm sure there are others, but these are the most significant at the moment.
Comment 1 Joanmarie Diggs (IRC: joanie) 2009-02-15 02:07:32 UTC 
Created attachment 128746 [details] [review]
fix for the issues in the opening report

This fix is limited to updateBraille in the Gecko script. PARCed.

I'm not sure if we also want to commit this to the gnome-2-24 branch or not. On the one hand it seems safe and good. On the other hand, I'm not sure if it's relying upon the most recent (significant) patch I checked into trunk (but not yet for the gnome-2-24 branch) for bug 571058 (http://bugzilla.gnome.org/attachment.cgi?id=128693&action=view). (Yeah, I know, I should find out. :-) )

Will, thoughts?
Comment 2 Willie Walker 2009-02-15 16:13:53 UTC 
(In reply to comment #1)
> I'm not sure if we also want to commit this to the gnome-2-24 branch or not.
...
> ...(Yeah, I know, I should find out. :-) )
> Will, thoughts?

We are *close* to putting the bigger patch for bug 571058 into gnome-2-24, so if you can wait until we figure that out (Monday?), then this can wait for that.  However, if you end up testing and discover that this doesn't require the to-be-committed patch to bug 571058, I'll trust your judgement on what to do.