After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 571383 - Deprecated GTK calls in #ifdef HILDON
Deprecated GTK calls in #ifdef HILDON
Status: RESOLVED FIXED
Product: cheese
Classification: Applications
Component: general
git master
Other Linux
: Normal trivial
: 2.26
Assigned To: Cheese Maintainer(s)
Cheese Maintainer(s)
Depends on: 572273
Blocks: 585692
 
 
Reported: 2009-02-12 02:34 UTC by Thomas Andersen
Modified: 2009-06-13 23:12 UTC
See Also:
GNOME target: 2.28.x
GNOME version: ---

Attachments
removes calls to deprecated GTK functions (2.18 KB, patch)
2009-02-12 02:35 UTC, Thomas Andersen 		committed Details | Review
use gtk_activatable_set_related_action instead of gtk_action_connect_proxy (2.12 KB, patch)
2009-03-03 18:14 UTC, Filippo Argiolas 		committed Details | Review

Description Thomas Andersen 2009-02-12 02:34:42 UTC 
There is still a few calls to deprecated GTK functions left in #ifdef HILDON case.

Patch is untested.
Comment 1 Thomas Andersen 2009-02-12 02:35:40 UTC 
Created attachment 128512 [details] [review]
removes calls to deprecated GTK functions
Comment 2 daniel g. siegel 2009-02-15 19:56:55 UTC 
seems ok to me, please commit it
Comment 3 Thomas Andersen 2009-02-16 16:22:35 UTC 
committed in r1191:
http://svn.gnome.org/viewvc/cheese?view=revision&revision=1191
Comment 4 André Klapper 2009-02-18 15:22:35 UTC 
Cheese still uses gtk_action_connect_proxy. See dependency bug.
Comment 5 Filippo Argiolas 2009-03-03 18:14:01 UTC 
Created attachment 129959 [details] [review]
use gtk_activatable_set_related_action instead of gtk_action_connect_proxy

This patch should remove remaining deprecated calls.
Anyway, gtk_action_connect_proxy has been deprecated recently in unstable gtk+ and is marked as "since 2.16"... isn't it a bit early to commit this patch?
Comment 6 Filippo Argiolas 2009-03-03 18:24:20 UTC 
(In reply to comment #5)
> and is marked as "since 2.16"... isn't it a bit early to commit this patch?

s/and is marked/and its replacement is marked/
Comment 7 daniel g. siegel 2009-03-03 19:01:42 UTC 
doesnt gnome 2.26 base on gtk 2.16?
Comment 8 André Klapper 2009-03-03 19:07:50 UTC 
(In reply to comment #7)
Yes. It's more about "I want to be able to use cheese 2.26 with gtk 2.14" packagers, but it's up to project maintainers to decide.
Comment 9 daniel g. siegel 2009-03-03 19:11:34 UTC 
ok sure, we can wait
Comment 10 André Klapper 2009-04-01 14:58:11 UTC 
Can we ifdef this and get it in? :-)
Comment 11 André Klapper 2009-04-24 19:10:08 UTC 
...or now that you've branched just get this in for 2.27.1? :)
Comment 12 Filippo Argiolas 2009-04-24 19:17:51 UTC 
(In reply to comment #11)
> ...or now that you've branched just get this in for 2.27.1? :)

Done :)