GNOME Bugzilla – Bug 571360
Bad appearance for GtkEntry with progress
Last modified: 2009-04-04 13:20:28 UTC
GTK+ 2.15/16 introduces the ability to put a progress in a GtkEntry. Unfortunately the appearence in Clearlooks is really bad (I've not tested other default themes, sorry), see the attached screeenshot. By now the only application using this GtkEntry feature is Epiphany, but could be good fix it ASAP, for 2.26 release (this is the reason I've set severity:major).
Created attachment 128496 [details] GtkEntry test application in Clearlooks See the bad white/double border around progress in bottom GtkEntry
Any idea/mockup for the look?
Created attachment 128507 [details] Small implementation Ideas? Index: engines/clearlooks/src/clearlooks_style.c =================================================================== --- engines/clearlooks/src/clearlooks_style.c (revisione 1305) +++ engines/clearlooks/src/clearlooks_style.c (copia locale) @@ -848,6 +848,24 @@ x, y, width, height, 10 - (int)(elapsed * 10.0) % 10); } + else if (DETAIL ("entry-progress")) + { + /* Draw the progresbar inside the entry, + * we should manage this clearlooks_draw.c + * Temporary here only for testing. + */ + + cairo_rectangle (cr, x+1, y+1, width-2, height-2); + cairo_set_source_rgba (cr, colors->spot[1].r, + colors->spot[1].g, + colors->spot[1].b, 0.5); + cairo_fill (cr); + cairo_rectangle (cr, x+1.5, y+1.5, width-3, height-3); + cairo_set_source_rgba (cr, colors->spot[2].r, + colors->spot[2].g, + colors->spot[2].b, 0.5); + cairo_stroke (cr); + } else if (DETAIL ("optionmenu")) { WidgetParameters params;
This will only be available with GTK+ 2.16, which will not happen for 2.26. So while it would be nice to have for 2.26, it "only" needs to be done for 2.28.
Created attachment 128558 [details] quick gimp touchup Your idea is great, but I'm for something without white padding and borders on top and bottom. A really really soft gradient, providing a little "volume" to progress, could be explored too..
Created attachment 128559 [details] Glitches in previous example code To reproduce: 1) launch gtk+/tests/testentryicons 2) increase from 0.00 to X.XX the progress entrues using Properties button 3) decrease the progress to 0.00 OK, it's very rare, I know :D
(In reply to comment #4) > This will only be available with GTK+ 2.16, which will not happen for 2.26. So > while it would be nice to have for 2.26, it "only" needs to be done for 2.28. > No, GTK 2.16 will be used in GNOME 2.26
Just for reference: similar stuff in iPod/iPhoneTouch http://www.spirituality.org.za/uploaded_images/MTN-South-Africa-iPhone-safari-loading-702411.jpg
(In reply to comment #5) > Created an attachment (id=128558) [edit] > quick gimp touchup > > Your idea is great, but I'm for something without white padding and borders on > top and bottom. > > A really really soft gradient, providing a little "volume" to progress, could > be explored too.. > It can't be implemented
Well, I think that my patch from bug #546285 should go into GTK+, then we should be able to properly theme the GtkEntry progress drawing.
This has already been (mostly) fixed in gtk-engines 2.18.0. If there should be any more improvements or there are some issues, please open new bugs.