Bug 571126 - make fails because meta_spew_event was defined but not used (--disable-verbose)
make fails because meta_spew_event was defined but not used (--disable-verbose)
Status: RESOLVED FIXED
Product: metacity
Classification: Other
Component: general
trunk
Other All
: Normal minor
: ---
Assigned To: Metacity maintainers list
Metacity maintainers list
:
Depends on:
Blocks:
  Show dependency tree
 
Reported: 2009-02-10 04:32 UTC by Alister
Modified: 2009-02-11 04:34 UTC (History)
1 user (show)

See Also:
GNOME target: ---
GNOME version: ---

Attachments
Disable declarations and definitions not used in non-verbose mode (1.27 KB, patch)
2009-02-10 16:55 UTC, Matt Kraai 		committed Details | Diff | Review
View All Add an attachment (proposed patch, testcase, etc.)

Description Alister 2009-02-10 04:32:30 UTC 
Please describe the problem:
With svn from a couple of weeks ago make failed with a message about meta_spew_event being defined but not used (or something along those lines).
I deleted the definition to compile successfully, but I've just had a quick look, and although I'm pretty ignorant it looks to me like the problem was because I configured with --disable-verbose

Steps to reproduce:


Actual results:


Expected results:


Does this happen every time?


Other information:
Comment 1 Matt Kraai 2009-02-10 16:55:19 UTC 
Created attachment 128391 [details] [review]
Disable declarations and definitions not used in non-verbose mode

I was able to reproduce this problem with the trunk using --disable-verbose-mode, as well as a similar problem with meta_window_queue_names.  The attached patch fixes both issues.
Comment 2 Thomas Thurman 2009-02-11 04:34:52 UTC 
Committed with thanks.
Note You need to log in before you can comment on or make changes to this bug.