GNOME Bugzilla – Bug 571033
stocks not automaticly refreshed
Last modified: 2018-03-12 12:44:04 UTC
Please describe the problem: Stocks are not always (never?) automaticly refreshed. Steps to reproduce: 1. check refresh time 2. wait a long time 3. check again Actual results: refresh time still remains on first time Expected results: refresh time updates Does this happen every time? not sure Other information: the refresh function in quotes.py does not return True. Adding it resolves the problem.
I can confirm this behaviour for 2.26.1, as well as latest svn revision (rev. 11454). It is indeed simply missing the "return True" at the end of the QuoteUpdater.refresh() method in quotes.py. Therefore, the stocks are only refreshed once, and then the periodic timer is discarded due to the missing True return value. See following patch.
Created attachment 136995 [details] [review] fixing the not-working auto refresh function
Btw., bug #566923 is a duplicate of this bug.
*** Bug 566923 has been marked as a duplicate of this bug. ***
Created attachment 138931 [details] [review] makes the auto refresh rate configurable Since the auto refresh rate is now working with the above patch, users might want to configure it to other values than the default of 10 or 15 minutes. This patch adds a config file and a respective field to the preferences ui. Refresh rates are allowed from 5 minutes to 5 hours. This patch needs translation of the new label saying 'Auto Refresh Rate', whereas the label 'Minutes' gets already translated.
The first patch has been committed to git master. I haven't yet reviewed the second patch.
Created attachment 141962 [details] [review] makes the auto refresh rate configurable Updated patch, another patch that was merged into master conflicts with the obsolete version of this patch.
Invest applet has been removed because Yahoo Finance API is no longer available.