After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 570576 - Klondike: Changing from single to three card deal moves waste slot
Klondike: Changing from single to three card deal moves waste slot
Status: RESOLVED FIXED
Product: aisleriot
Classification: Other
Component: general
pre-3.0
Other All
: Normal trivial
: ---
Assigned To: aisleriot-maint
aisleriot-maint
Depends on:
Blocks:
 
 
Reported: 2009-02-04 23:28 UTC by Thomas Andersen
Modified: 2011-12-06 19:13 UTC
See Also:
GNOME target: ---
GNOME version: ---



Description Thomas Andersen 2009-02-04 23:28:47 UTC
SSIA
Comment 1 Christian Persch 2009-02-04 23:36:45 UTC
It's this code in board*.c:

  /* FIXMEchpe: what exactly is the purpose of the following lines? */
  if (slot->expanded_right)
    xofs = yofs;
  if (slot->expanded_down)
    yofs = xofs;

which I've never been able to figure out the purpose of.
Comment 2 Thomas Andersen 2009-09-22 21:03:03 UTC
I have played a few games with this code removed and I did not notice any problems without it.

Maybe we should just delete it and see if anything breaks?
Comment 3 Christian Persch 2011-04-25 12:05:46 UTC
Mass-moving only open aisleriot bugs to the new product. Search for "aisleriot-mass-move" to filter them.
Comment 4 Christian Persch 2011-12-06 19:13:10 UTC
Fixed on master.