After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 570356 - aac typefinder failure
aac typefinder failure
Status: RESOLVED FIXED
Product: GStreamer
Classification: Platform
Component: gst-plugins-base
git master
Other Linux
: Normal normal
: 0.10.23
Assigned To: GStreamer Maintainers
GStreamer Maintainers
Depends on:
Blocks:
 
 
Reported: 2009-02-03 12:49 UTC by Stefan Sauer (gstreamer, gtkdoc dev)
Modified: 2009-02-03 14:49 UTC
See Also:
GNOME target: ---
GNOME version: ---



Description Stefan Sauer (gstreamer, gtkdoc dev) 2009-02-03 12:49:27 UTC
$ gst-typefind AAC_128k.aac
AAC_128k.aac - audio/x-flac
$ file AAC_128k.aac
AAC_128k.aac: MPEG ADTS, AAC, v2 LC, 44.1 kHz, stereo

$ hexdump -C AAC_128k.aac
00000000  ff f9 50 80 89 1f fc 21  5c c6 80 03 a8 7f e7 7f  |..P....!\.......|
00000010  b4 87 b7 d0 3b f6 fc 02  00 00 00 00 8e 91 42 0e  |....;.........B.|
00000020  17 76 43 8d f5 32 79 9d  31 3e 07 c5 89 f1 be 32  |.vC..2y.1>.....2|
00000030  4f 8d 71 d2 7c 8b 91 93  e3 bc 44 96 d9 e4 c8 92  |O.q.|.....D.....|
00000040  6a 59 36 40 27 1a 3f 0a  d2 11 68 90 9a 72 65 94  |jY6@'.?...h..re.|
00000050  4e 7c 5e 14 44 06 62 05  29 02 93 84 10 00 00 12  |N|^.D.b.).......|
00000060  f9 65 f8 fc 25 e8 1f 8e  84 7e 96 f6 92 1a 3f 53  |.e..%....~....?S|
00000070  93 e0 9b 82 1c 2b 9b 13  e4 9c 18 97 11 c3 93 f7  |.....+..........|
00000080  46 00 9f 88 bd 10 4b c1  dd 5c 96 06 21 3e 99 e7  |F.....K..\..!>..|
00000090  5e 17 cf c4 bd 41 d9 09  7b 6f ac 91 e9 de 4b 27  |^....A..{o....K'|
000000a0  c9 b9 01 2f 20 f4 42 5c  47 ab 92 1f 85 c9 6e f5  |.../ .B\G.....n.|
000000b0  c4 b5 7c 44 9e f3 08 4f  5a 72 7a 98 a4 38 0e c7  |..|D...OZrz..8..|
000000c0  8e 71 42 5c 0b 41 c7 2a  f1 cb 5c 73 26 4b 11 86  |.qB\.A.*..\s&K..|
000000d0  25 81 c0 92 8d 10 94 38  64 a0 c1 25 0a 11 28 50  |%......8d..%..(P|
000000e0  49 40 82 49 ef 24 f7 92  7b c9 39 a4 9c f2 4e 70  |I@.I.$..{.9...Np|
000000f0  01 2f c2 3f d3 b2 3d c3  c8 c4 bf 2b de 33 23 f4  |./.?..=....+.3#.|
Comment 1 Stefan Sauer (gstreamer, gtkdoc dev) 2009-02-03 13:14:28 UTC
flac 2>&1 -t /home/ensonic/video/mp4/odin.wipsl.com/media/wlan/AAC_128k.aac | more

flac 1.2.1, Copyright (C) 2000,2001,2002,2003,2004,2005,2006,2007  Josh Coalson
flac comes with ABSOLUTELY NO WARRANTY.  This is free software, and you are
welcome to redistribute it under certain conditions.  Type `flac' for details.

AAC_128k.aac: *** Got error code 1:FLAC__STREAM_DECODER_ERROR_STATUS_BAD_HEADER
AAC_128k.aac: *** Got error code 0:FLAC__STREAM_DECODER_ERROR_STATUS_LOST_SYNC
AAC_128k.aac: *** Got error code 1:FLAC__STREAM_DECODER_ERROR_STATUS_BAD_HEADER
AAC_128k.aac: *** Got error code 0:FLAC__STREAM_DECODER_ERROR_STATUS_LOST_SYNC
Comment 2 Stefan Sauer (gstreamer, gtkdoc dev) 2009-02-03 14:13:37 UTC
This helps in the current case. I just wonder if we want to use GST_TYPE_FIND_LIKELY-1 for flac until it also computes the CRC for the whole header.


commit 080493ccff20b288ab2c9fb399e71d563c2bd621
Author: Stefan Kost <ensonic@users.sf.net>
Date:   Tue Feb 3 15:26:08 2009 +0200

typefind: Make the flac check more tight to not mistace some aac files for flac. Fixes #570356.
    
Add comments about the flac format. Tighten the check to not allow values that
refer to headers.