After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 570304 - TextEdit entry via Button Press and Hold
TextEdit entry via Button Press and Hold
Status: RESOLVED FIXED
Product: dia
Classification: Other
Component: general
devel
Other All
: Normal minor
: 0.97
Assigned To: Dia maintainers
Dia maintainers
Depends on:
Blocks:
 
 
Reported: 2009-02-03 03:53 UTC by Robert Young
Modified: 2009-02-06 15:43 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
Initial patch for comments (6.19 KB, patch)
2009-02-03 04:36 UTC, Robert Young 		committed Details | Review

Description Robert Young 2009-02-03 03:53:01 UTC 
Currently the mouse cannot be used (via click, double click, modified click) to edit text. A separate text edit tool is required.
To improve this, a button press and hold functionality is proposed.
To use: Select text with mouse button and hold for more than 1second. Text edit mode is then entered on the object.

Other information:
Comment 1 Robert Young 2009-02-03 04:36:05 UTC 
Created attachment 127808 [details] [review]
Initial patch for comments

Here is an implementation of entering text edit mode via a "press and hold". Implemented a generic button_press_hold callback for all tools in disp_callbacks. Then added a button_press_hold implementation in modify_tool. Please try it out, and suggest improvements!
Comment 2 Hans Breuer 2009-02-06 15:43:25 UTC 
Thanks! Patch looks fine to me - except some whitespace/coding style issues, which I've corrected. One day I should document them ;-) (tabwidth of Dia is 8, etc.).


2009-02-06  Hans Breuer  <hans@breuer.org>

	* app/disp_callbacks.c app/tool.h app/modify_tool.c : also allow
	TextEdit entry via Button Press and Hold - patch from  Robert Young
	fixing bug #570304