After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 570172 - GiggleRevisionInfoAction breaks with GTK+ 2.15 SVN
GiggleRevisionInfoAction breaks with GTK+ 2.15 SVN
Status: RESOLVED FIXED
Product: giggle
Classification: Other
Component: UI: History View
HEAD
Other Linux
: Normal critical
: 0.4.91
Assigned To: Mathias Hasselmann (IRC: tbf)
: 571691 (view as bug list)
Depends on:
Blocks:
 
 
Reported: 2009-02-02 05:14 UTC by Danielle Madeley
Modified: 2009-02-17 14:25 UTC
See Also:
GNOME target: ---
GNOME version: ---



Description Danielle Madeley 2009-02-02 05:14:16 UTC
UI always says "Change 0 of 0", although the up/down buttons work.

It looks like the "label" property isn't proxied back to where it goes, maybe?

No problem with GTK+ 2.14.4.
Comment 1 Christian Persch 2009-02-02 14:45:16 UTC
Probably due to the recent gtkaction changes on gtk trunk; this bug probably should be moved to gtk+.
Comment 2 Mathias Hasselmann (IRC: tbf) 2009-02-14 16:39:11 UTC
*** Bug 571691 has been marked as a duplicate of this bug. ***
Comment 3 Mathias Hasselmann (IRC: tbf) 2009-02-14 16:40:10 UTC
> Opened by Jonathon Jongsma (jonner) (reporter, developer, points: 19)
> 2009-02-13 22:59 UTC [reply]
>
> Running current HEAD from git, every change set I select, the diff view says
> "Change 0 of 0".  It seems to work OK (e.g. I can navigate through the
> different diff hunks), so it's only the text display that appears broken.  I
> don't know if this is related to bug #571690 that I just filed or not.
Comment 4 Mathias Hasselmann (IRC: tbf) 2009-02-15 01:05:02 UTC
Fixed in 1282360362790affa5d21dc457eb5f9ce4f7d567

No idea why it worked with old GTK+ versions.
It shouldn't, as GtkToolItem doesn't have a label property.
Comment 5 Danielle Madeley 2009-02-17 04:55:39 UTC
It still says "Uncommitted Changes" rather than giving the commit id.
Comment 6 Mathias Hasselmann (IRC: tbf) 2009-02-17 08:38:22 UTC
Second try: 0b69cd1f0466c86265e9abd04132e0f5db2458c3
Comment 7 Danielle Madeley 2009-02-17 14:25:07 UTC
Looks good.