After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 569938 - Non-source-dir build failure
Non-source-dir build failure
Status: RESOLVED FIXED
Product: gnome-keyring
Classification: Core
Component: general
git master
Other Linux
: Normal minor
: ---
Assigned To: GNOME keyring maintainer(s)
GNOME keyring maintainer(s)
Depends on:
Blocks: 569778
 
 
Reported: 2009-01-31 03:44 UTC by Theppitak Karoonboonyanan
Modified: 2009-01-31 09:02 UTC
See Also:
GNOME target: ---
GNOME version: 2.25/2.26

Attachments
Add $(srcdir) in Makefile.am (535 bytes, patch)
2009-01-31 03:47 UTC, Theppitak Karoonboonyanan 		accepted-commit_now Details | Review
Adjusted rule (503 bytes, patch)
2009-01-31 08:23 UTC, Theppitak Karoonboonyanan 		none Details | Review

Description Theppitak Karoonboonyanan 2009-01-31 03:44:58 UTC 
When building gnome-keyring outside source tree, the following error was found:

- In pkcs11/gck, asn1Parser cannot find pk.asn, which is in $(srcdir), not $(builddir). The same applies to pkix.asn:

---8<---
make[3]: Entering directory `/home/thep/build/gnome_svn/gnome-keyring/pkcs11/gck'
asn1Parser -o asn1-def-pk.h pk.asn 
asn1Parser: FILE pk.asn NOT FOUND
make[3]: *** [asn1-def-pk.h] Error 1
make[3]: Leaving directory `/home/thep/build/gnome_svn/gnome-keyring/pkcs11/gck'
make[2]: *** [all-recursive] Error 1
make[2]: Leaving directory `/home/thep/build/gnome_svn/gnome-keyring/pkcs11'
make[1]: *** [all-recursive] Error 1
make[1]: Leaving directory `/home/thep/build/gnome_svn/gnome-keyring'
make: *** [all] Error 2
---8<---
Comment 1 Theppitak Karoonboonyanan 2009-01-31 03:47:53 UTC 
Created attachment 127604 [details] [review]
Add $(srcdir) in Makefile.am

This patch makes it build.
Comment 2 Stef Walter 2009-01-31 07:16:09 UTC 
Thanks for the patch. Looks good. Please commit with a ChangeLog.
Comment 3 Theppitak Karoonboonyanan 2009-01-31 08:23:43 UTC 
Created attachment 127610 [details] [review]
Adjusted rule

I adjusted the patch a little bit, using source variable instead of adding $(srcdir)/ prefix.
Comment 4 Theppitak Karoonboonyanan 2009-01-31 09:02:51 UTC 
2009-01-31  Theppitak Karoonboonyanan  <thep@linux.thai.net>

        * pkcs11/gck/Makefile.am: Fix rules to allow non-source-dir builds.
        Fixes bug #569938