After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 569835 - Orca should support the ARIA haspopup attribute
Orca should support the ARIA haspopup attribute
Status: RESOLVED FIXED
Product: orca
Classification: Applications
Component: general
unspecified
Other opensolaris
: Normal normal
: 2.24.4
Assigned To: Willie Walker
Orca Maintainers
Depends on:
Blocks: 404403
 
 
Reported: 2009-01-30 15:30 UTC by Willie Walker
Modified: 2009-01-31 15:57 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
First pass at this (2.82 KB, patch)
2009-01-30 18:54 UTC, Willie Walker 		none Details | Review
Patch to include regression test modifications (10.54 KB, patch)
2009-01-31 15:49 UTC, Willie Walker 		committed Details | Review

Description Willie Walker 2009-01-30 15:30:56 UTC 
The ARIA folks invented a new way to express the menu role: a push button or menu item with an attribute of "haspopup:true":

http://www.w3.org/TR/wai-aria/#haspopup

We need to support this.  An example of these beasts can be found at http://archive.dojotoolkit.org/nightly/dojotoolkit/dijit/tests/form/test_Button.html -- all the menu items on that page are push buttons with the "haspopup:true" attribute.
Comment 1 Willie Walker 2009-01-30 18:54:17 UTC 
Created attachment 127568 [details] [review]
First pass at this

This seems to be a doubleplusgood patch that goodifies the previous ungood code that didn't recognize menu and menu items that disguised themselves as buttons with a haspopup:true attribute.  It pylints well and regression tests well except for those tests that now expose things as menus.
Comment 2 Willie Walker 2009-01-31 15:49:48 UTC 
Created attachment 127631 [details] [review]
Patch to include regression test modifications

Committed to trunk and gnome-2-24.