Seems to work fine for me. Could you retry with 2.26.0 please?

I have disabled this setting, restarted empathy, re-enabled this setting and restarted the computer. Still empathy was not started on login.

Does NetworkManager detects you as connected when Empathy is started?

I don't understand your question Guillaume. This bug is about Empathy not starting at session start, nothing to do with whether or not the network is up.

Oh, it looks like a misunderstanding of what the option is supposed to do, it is *not* to add empathy to the default GNOME session, it's about connecting accounts when Empathy is started.

I guess what you'd want is akin bug 506311.

"Automatically connect on startup" setting is confusing - users may expect this to run Empathy on login.

Can we change the label and make it obvious that this setting means "go online when you start Empathy"?

How about:

'Automatically connect to accounts when Empathy starts'

If this is okay I shall make a patch

I'd rather remove the checkbox and replace it by:

Status when starting Empathy: [Available]
and use the presence chooser to let user choose any status by default.

Maybe:
"Automatically connect on Empathy startup"

I think that "Automatically connect on Empathy startup" is a good idea, I had the same felling about the "Automatically connect on startup" but I'd like to suggest that Empaphy should remember users last status.

Comment#8 would be fine.

From the downstream bug: (comment #11)
"I'm with MPT and co. on this. The option should be removed entirely. Why would you *not* want to go online when starting Empathy? If you're *starting* Empathy, you're signalling that you want to go online."

I'll attach a patch to do exactly that. Note that this doesn't remove the gsettings key, so the option remains accessible.

Created attachment 168902 [details] [review]
Patch that removes the automatic connect startup option.

(In reply to comment #12)
> From the downstream bug: (comment #11)
> "I'm with MPT and co. on this. The option should be removed entirely. Why would
> you *not* want to go online when starting Empathy? If you're *starting*
> Empathy, you're signalling that you want to go online."

If you want to connect as Invisible and not appear as online even for a few seconds?

(In reply to comment #14)
> (In reply to comment #12)
> > From the downstream bug: (comment #11)
> > "I'm with MPT and co. on this. The option should be removed entirely. Why would
> > you *not* want to go online when starting Empathy? If you're *starting*
> > Empathy, you're signalling that you want to go online."
> 
> If you want to connect as Invisible and not appear as online even for a few
> seconds?

Hmm, good point.
In this case, your proposition is good: 
Status when starting Empathy: [Available]
Where [] would contain the statuses and a "Last status" option.

Created attachment 175848 [details] [review]
Patch that fixes the bug by removing the option and adding a status combobox

Here's my second attempt at fixing the bug. It adds a status combobox that allows to choose any status you want Empathy to use at start up. Please review :)

I should note though that Glade is not playing nice with me, like usual :( the glade-preferences.ui has so many insertions and deletions, though at the end it isn't a big change. Is this a problem?

Review of attachment 175848 [details] [review]:

Thanks for your patch. Here is my review.

Your patch introduced some trailing spaces, you can use "make check" to catch them.

Ideally, the chooser should also include the preset defined by the EmpathyPresenceChooser.

::: libempathy/empathy-gsettings.h
@@ +28,3 @@
 #define EMPATHY_PREFS_SCHEMA "org.gnome.Empathy"
 #define EMPATHY_PREFS_USE_CONN                     "use-conn"
+#define EMPATHY_PREFS_STARTUPSTATUS                "startup-status"

You should also update data/org.gnome.Empathy.gschema.xml.in

::: src/empathy.c
@@ +512,3 @@
     }
 
+  startup_status = g_settings_get_int (self->gsettings, EMPATHY_PREFS_STARTUPSTATUS);

That's wrong, you shouldn't store an int but a (s, s) tuple containing the status and the message. Like we do in the presence chooser. See also http://telepathy.freedesktop.org/spec/Connection_Interface_Simple_Presence.html

(In reply to comment #17)
> Review of attachment 175848 [details] [review]:
> 
> Thanks for your patch. Here is my review.
> 
> Your patch introduced some trailing spaces, you can use "make check" to catch
> them.
> 
> Ideally, the chooser should also include the preset defined by the
> EmpathyPresenceChooser.
> 
> ::: libempathy/empathy-gsettings.h
> @@ +28,3 @@
>  #define EMPATHY_PREFS_SCHEMA "org.gnome.Empathy"
>  #define EMPATHY_PREFS_USE_CONN                     "use-conn"
> +#define EMPATHY_PREFS_STARTUPSTATUS                "startup-status"
> 
> You should also update data/org.gnome.Empathy.gschema.xml.in

Whoops, I changed org.gnome.Empathy.gschema.xml instead, that's why I didn't notice it. Thanks for noticing :)

> ::: src/empathy.c
> @@ +512,3 @@
>      }
> 
> +  startup_status = g_settings_get_int (self->gsettings,
> EMPATHY_PREFS_STARTUPSTATUS);
> 
> That's wrong, you shouldn't store an int but a (s, s) tuple containing the
> status and the message. Like we do in the presence chooser. See also
> http://telepathy.freedesktop.org/spec/Connection_Interface_Simple_Presence.html

Okay, will get to it. Thanks for reviewing :)

Well, after checking the code, I don't see a (s, s) tuple in the presence chooser code. Do you mean get_state_and_status () in empathy-presence-chooser.c? Or am I simply blinded by my n00biness? :p

We want to save 2 things:
- The well known string identified of the presence type (such as 'available', 'away', etc). You can get it using empathy_presence_to_str().
- The status message which is user type (like "At the Pub" for example).

Looking at empathy-presence-chooser, I thin it's doing too many things to be of use it. You'll probably have to use a GtkComboBox and the EmpathyStatusPresets directly. See empathy_presence_chooser_create_menu(), that's where we fill the chooser with the different presences.

*** Bug 649833 has been marked as a duplicate of this bug. ***

This bug has gone off track into a discussion of how a user chosses their online status when they start Empathy. That is not what this bug is about - please make a new bug specific to that issue (I agree about making a combo box)

This bug is about the very general problem, at least in Gnome, of how to have applications start at login. That problem has not seen any movement as far as I know.

I was just wondering if there was any progress on this bug? Are there still plans to add a combo box for setting a default status at login? What about the issue regarding confusion over the purpose of the auto-connect option?

-- GitLab Migration Automatic Message --

This bug has been migrated to GNOME's GitLab instance and has been closed from further activity.

You can subscribe and participate further through the new bug through this link to our GitLab instance: https://gitlab.gnome.org/GNOME/empathy/issues/39.