After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 569409 - minor issues in gdm-screenshot.c
minor issues in gdm-screenshot.c
Status: RESOLVED FIXED
Product: gdm
Classification: Core
Component: general
unspecified
Other Linux
: Normal trivial
: ---
Assigned To: GDM maintainers
GDM maintainers
Depends on:
Blocks:
 
 
Reported: 2009-01-28 00:28 UTC by Christian Persch
Modified: 2010-06-17 00:41 UTC
See Also:
GNOME target: ---
GNOME version: ---



Description Christian Persch 2009-01-28 00:28:28 UTC
From gdm-screenshot.c:main()

        /* Option parsing */
        ctx = g_option_context_new (_("Take a picture of the screeen"));

Should use N_() here; the set_translation_domain call below takes care of translation.

        g_option_context_set_translation_domain (ctx, GETTEXT_PACKAGE);
        g_option_context_add_main_entries (ctx, options, NULL);
        g_option_context_parse (ctx, &argc, &argv, NULL);

Fails to check for errors from parsing.

        g_option_context_free (ctx);

        gtk_init (&argc, &argv);

Probably, instead of this extra gtk_init call, you should simply add the gtk option group to the option context above with

   g_option_context_add_group (ctx, gtk_get_option_group (TRUE));
Comment 1 William Jon McCann 2010-06-17 00:41:07 UTC
Thanks.

commit 302c4c6c080da5f8872e1a80fa6b2526fb307816
Author: William Jon McCann <jmccann@redhat.com>
Date:   Wed Jun 16 20:40:20 2010 -0400

    Fix minor issues with screenshot tool
    
    As suggested by Christian Persch
    https://bugzilla.gnome.org/show_bug.cgi?id=569409