After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 569294 - org.freedesktop.NetworkManager.Connection.Active in xml twice
org.freedesktop.NetworkManager.Connection.Active in xml twice
Status: RESOLVED FIXED
Product: NetworkManager
Classification: Platform
Component: general
git master
Other Linux
: Normal normal
: ---
Assigned To: Dan Williams
Dan Williams
Depends on:
Blocks:
 
 
Reported: 2009-01-27 06:40 UTC by Havoc Pennington
Modified: 2011-01-25 18:55 UTC
See Also:
GNOME target: ---
GNOME version: ---



Description Havoc Pennington 2009-01-27 06:40:49 UTC
nm-vpn-connection.xml seems to have an extra copy of org.freedesktop.NetworkManager.Connection.Active in it?
Comment 1 Dan Williams 2009-01-28 17:22:54 UTC
Yeah, its duplicated there because internally, the VPN connection objects provide the same D-Bus interface as the ActiveConnection objects.  I don't think dbus-glib can attach more than one object info to the same GObject; thus we can't attach *both* the processed data from nm-active-connection.xml and nm-vpn-connection.xml to NMVPNConnection objects internally using dbus_g_object_type_install_info().  Not entirely sure what to do here; I assume this is an issue in the NM D-Bus spec?
Comment 2 Havoc Pennington 2009-01-31 22:30:22 UTC
ugh, I guess I could have guessed it would be dbus-glib's fault :-P

this comes up because I wrote a dbus-introspection-to-javascript converter for gjs dbus bindings, and it spits out the active connection interface twice, which makes the javascript code throw at runtime.

I worked around it for now by just editing nm-vpn-connection.xml locally ... I could hack it in the dbus2js script, but it's a little tricky from the script to know which active connection xml is the good one and which is the extra one. (The extra one is missing PropertiesChanged and the state enum, so you have to use the one in nm-active-connection.xml to get working bindings.)

Anyway it sounds like we should move the bug to dbus-glib, I don't really have any ideas for how NetworkManager can fix this without a fix there.

Comment 3 Dan Williams 2011-01-25 18:55:37 UTC
Fixed, finally:

bc6fc7b910435aae00ef54db972a3e8359700d09 (master)
af4bcf3ee9dd40ac5b5b5dbe9160ffd821380e50 (0.8.x)