After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 569182 - Script-Fu: Drop Shadow color selection eyedropper
Script-Fu: Drop Shadow color selection eyedropper
Status: RESOLVED OBSOLETE
Product: GIMP
Classification: Other
Component: libgimp
2.6.4
Other Windows
: Normal minor
: ---
Assigned To: GIMP Bugs
GIMP Bugs
Depends on:
Blocks:
 
 
Reported: 2009-01-26 12:22 UTC by ovidiu.crisu
Modified: 2009-02-14 12:34 UTC
See Also:
GNOME target: ---
GNOME version: ---


Attachments
Valgrind log (3.29 KB, text/plain)
2009-01-27 20:15 UTC, tobias
Details

Description ovidiu.crisu 2009-01-26 12:22:23 UTC
When using the Drop Shadow script, if I want to change the color of the shadow using the eyedropper tool, the eyedropper only works inside the color selection window, not anywhere on the screen.
Comment 1 Michael Schumacher 2009-01-26 14:27:34 UTC
I can't reproduce this, the picker seems to work everywhere outside of the window as well.
Comment 2 Alec_Burgess 2009-01-27 03:34:02 UTC
Is OP using Windows with TweakUI X-Mouse option (or equivalent linux option)?

I have same problem with all eyedropper use wherever its made available. I've just assumed its an unavoidable consequence of the X-Mouse option. When I move cursor outside of window where it was invoked the window its over (whether from GIMP or another program) gets focus and the cursor changes from the eyedropper to the "normal" one.

I tested a couple of Windows freeware color pickers ... some work (apparently by temporarily disabling the auto-focus window under mouse?) eg. ColorMania http://users.pandora.be/eclypse/colormania.html and others don't (unless X-Mouse is turned off by user) eg. ColorPic http://www.iconico.com/colorpic/

For now I'm using ColorMania when I want to pick a color and pasting it into Gimp from clipboard. 
Comment 3 Alec_Burgess 2009-01-27 03:43:42 UTC
[Edit add to #2] Problem with color-picker in Gimp is a little different with filter drop-shadow than with main color-picker (eg. from foreground-background).
Cursor changes from picker as soon as leaving script-fu invoked color-picker but from main one it works in a image but changes to "normal" cursor as soon as it is over a non-gimp window or a utility-window (eg. toolbox).

It seems that the only non-gimp color pickers that work are ones that use click-and-drag then release to capture mode, rather than GIMP's Click then move, then click again to capture.
Comment 4 tobias 2009-01-27 20:15:46 UTC
Created attachment 127356 [details]
Valgrind log
Comment 5 Sven Neumann 2009-01-29 22:35:38 UTC
You can use the core color selection dialog that you reach from the fg/bg colors in the toolbox. It features a screen color picker.

Then drag from this dialog or from the color indicator in the toolbox to the script-fu dialog.
Comment 6 tobias 2009-01-30 10:49:58 UTC
(In reply to comment #4)
> Created an attachment (id=127356) [edit]
> Valgrind log
> 

Sorry, this log was not for this bug, but for Bug #569171. I'll add it there.
Comment 7 Tor Lillqvist 2009-02-09 00:40:53 UTC
Both the GIMP and GTK+ eyedropper seem to work for me on Windows, but for some reason colors can be picked only from the first monitor. 
Comment 8 Michael Schumacher 2009-02-09 10:00:31 UTC
Is this bug report still useful? 

IMO someone should summarize what does work (everything on my system) and what not, maybe in a new bug. Alec?
Comment 9 Alec_Burgess 2009-02-10 00:19:10 UTC
@Michael - for now I'll summarize what works on my system Windows XP SP3 GIMP 2.4.6 "official" windows distribution.

Summary:
Bug: Behavior of Script-fu Color selection.
Possible bug:  Behavior with multiple monitors - I can't test.
Bug or as designed?: Eyedropper can not be used with non-GIMP windows. 

(1) My assumption that TweakUI-Mouse-XMouse [Activation follows mouse] is involved was a red-herring. Behavior is same regardless of that setting except that as is its intent if I hover any window whether a GIMP window or an external window after the delay I've specified (500ms) the windows title-bar is turned to active.

(2) Use of eyedropper from Gimp color-picker [Change foreground color] invoked from the [Foreground and background colors] in toolbox is correct. After clicking the eyedropper the cursor changes to the eye-dropper when over ANY GIMP window (including the Open Image dialog - I wasn't sure if it might be different because its created by GTK+).
Question: I'm not sure if it is intended that it be possible to pick colors from non-Gimp windows (eg. Irfan, a browser window)? When I move outside GIMP windows to other windows the cursor changes to the normal one for that window and changes back to the eye-dropper when I re-enter a GIMP window.

(3) comment #7 form  Tor Lillqvist ""...but for some reason colors can be picked only from the first monitor" I can't verify. I only have a single display.
Also, I'm not sure what he means by GIMP eyedropper and GTK+ eyedropper?

(4) behavior of eyedropper when invoked from by clicking on [Color] button from Script-Fu: Drop Shadow: As  ovidiu reported it only works within the "Script-Fu color selection" window itself. If you move mouse outside the window it is changed to normal cursor. It changes back to eyedropper if you re-enter "Script-Fu color selection" window and works to select a color there.
(4b) It can also be used in the "parent" "Script-Fu: Drop Shadow" window. ie. when mouse enters that window cursor changes back to an eye-dropper and can be used to pick any white, black or color of the panel itself from that window. (Not a terribly useful feature!)
(4c)If eyedropper invoked from "Script-Fu: Drop Shadow" and current tool happens to be the Color Picker tool and you click inside a GIMP image window it changes the foreground color in toolbox but does NOT set the color in the "Script-Fu color selection" window.
Comment 10 Michael Schumacher 2009-02-10 09:43:12 UTC
This is a summary?
Comment 11 Tor Lillqvist 2009-02-10 09:59:22 UTC
Did you try actually try clicking in a non-GIMP window even if the cursor isn't an eye-dropper?
Comment 12 Alec_Burgess 2009-02-11 04:15:48 UTC
> This is a summary?
Here's the summary:
===
1 - Bug: Behavior of Script-fu Color selection.
2 - Possible bug:  Behavior with multiple monitors - I can't test.
3 - Bug or as designed?: Eyedropper can not be used with non-GIMP windows. 
===
> Did you try actually try clicking in a non-GIMP window even if the cursor isn't
an eye-dropper?
I have now! AFAICT clicking in non-GIMP windows does not get processed by GIMP at all. "Current" color does not change after click.


Comment 13 Alec_Burgess 2009-02-11 04:28:16 UTC
>>Did you try actually try clicking in a non-GIMP window even if the
>>cursor isn't an eye-dropper?
>
>I have now! AFAICT clicking in non-GIMP windows does not get
>processed by GIMP at all. "Current" color does not change after
>click.

Correction: 
If TweakUI X-Mouse is OFF clicking in non-GIMP window DOES change the "Current" color even though the cursor is not displayed as an eye-dropper.

If TweakUI X-Mouse is ON and click is made within the "activation delay (ms)" interval "Current" color is changed otherwise the click is received and processed by the window in which the cursor is located.

@Tor: thanks for prodding me to have another look at the behavior. I think I have it described correctly now.
Comment 14 Alec_Burgess 2009-02-11 05:09:52 UTC
> I think I have it ALMOST described correctly now.

Jeez ... this is embarrassing :-(

Turns out "Script-fu Color selection" is same as "Gimp color-picker [Change foreground color]" except that eye-dropper cursor is only shown when mouse is in "Script-fu Color selection" or its parent "Script-fu:Drop Shadow window".

Revised Summary:
===============
Two issues: eyedropper cursor display and "current" color change.
1. eyedropper cursor display:
1.1 from Script-fu color selection: eyedropper only displayed in Script-fu color selection window and parent Script-fu:Drop Shadow. In other GIMP windows and non-GIMP windows it changes to "normal" cursor for that window.
1.2 from GIMP color-picker [Change foreground color]: eyedropper displayed in any GIMP window. Changes to "normal" cursor outside them.
1.3 If cursor is NOT eyedropper click is also processed by the window over which cursor is located.

2 "current" color change:
2.1 (TweakUI/X-Mouse=OFF) or (TweakUI/X-Mouse=ON and click is within ""activation delay (ms)"):
2.1.1 "Current" color is correctly changed from both Script-fu and regular Color selection.
2.2 TweakUI/X-Mouse=ON and click is after ""activation delay (ms)": 
2.2.1 "Current" color is NOT changed and click is processed only by window cursor is in.

3. Multi-monitor problems: Not confirmed.
Comment 15 Sven Neumann 2009-02-11 18:58:30 UTC
This does not have anything to do with Script-Fu then. Please give this bug report a reasonable summary and mention the version of GTK+, so that we can reassign it.
Comment 16 Sven Neumann 2009-02-14 12:34:24 UTC
Let's close this as in favor of bug #571550 then.