After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 569042 - gailbooleancell does not seem to attend to changes to STATE_SENSITIVE
gailbooleancell does not seem to attend to changes to STATE_SENSITIVE
Status: RESOLVED FIXED
Product: gtk+
Classification: Platform
Component: Accessibility
2.15.x
Other All
: Normal normal
: ---
Assigned To: gtk-bugs
gtk-bugs
Depends on:
Blocks:
 
 
Reported: 2009-01-25 06:07 UTC by Joanmarie Diggs (IRC: joanie)
Modified: 2010-03-05 06:52 UTC
See Also:
GNOME target: ---
GNOME version: 2.23/2.24


Attachments
Proof of concept solution (1.88 KB, patch)
2009-01-25 06:10 UTC, Joanmarie Diggs (IRC: joanie)
committed Details | Review
new patch (2.09 KB, patch)
2010-01-19 07:50 UTC, Li Yuan
none Details | Review

Description Joanmarie Diggs (IRC: joanie) 2009-01-25 06:07:26 UTC
Gtk+ CellRendererToggles can be set to sensitive or insensitive. Examining these objects with Accerciser or Orca seems to indicate that STATE_SENSITIVE is exposed, and not removed when the CellRendererToggle's sensitivity is set to False.

I'm afraid my test case at the moment is a modified version of the OpenSolaris packagemanager. :-) I'll look around for (or create) a more readily available test case.
Comment 1 Joanmarie Diggs (IRC: joanie) 2009-01-25 06:10:32 UTC
Created attachment 127186 [details] [review]
Proof of concept solution

This patch solves the problem for me for the test case in question. I marked it as needs-work because:

1) I'm not familiar with gail
2) I'm not familiar with C

:-)

That said, this change conceptually seems appropriate and will make the state of CellRendererToggles accessible to users who are blind.

Thanks in advance for looking at this!
Comment 2 Li Yuan 2010-01-19 07:45:22 UTC
When I go through my bugs list I found I miss to review this patch. Sorry for delaying such a long time!

I think maybe you are looking for "activatable" property for gtkcellrenderertoggle. Because cell->renderer is a gtkcellrenderertoggle.
Comment 3 Li Yuan 2010-01-19 07:50:16 UTC
Created attachment 151740 [details] [review]
new patch

Does this patch fix this bug?
Comment 4 Joanmarie Diggs (IRC: joanie) 2010-02-15 19:06:52 UTC
(In reply to comment #3)
> Created an attachment (id=151740) [details] [review]
> new patch
> 
> Does this patch fix this bug?

I'm afraid it does not.

The test case is packagemanager. Both the Manage Boot Environments and the Manage Publishers dialogs have a checkbox which cannot be toggled. With your patch, these checkboxes/table cells still have state sensitive; with my patch they do not. Orca announces that an object is "grayed" (i.e. unavailable to be interacted with) when it lacks STATE_SENSITIVE.
Comment 5 Joanmarie Diggs (IRC: joanie) 2010-03-04 15:02:51 UTC
Li, I know you're busy, but since you were looking at Gtk+/Gail bugs which impact packagemanager.... Any thoughts on why what you're proposing here fails to solve the problem, but why patch does?

Thanks!
Comment 6 Li Yuan 2010-03-05 03:50:11 UTC
Sorry for late responding. I searched gtkcellrenderertoggle.c and find activatable property. Seems it doesn't work, and I just find gtkcellrenderer.c has sensitive property. Will try again today.
Comment 7 Li Yuan 2010-03-05 06:51:38 UTC
Confirm the fix and committed to trunk.

commit 4759da26348fd1063e2da2e8f85d7a7fa7b41acd
Author: Joanmarie Diggs <joanmarie.diggs@gmail.com>
Date:   Fri Mar 5 14:48:23 2010 +0800

    Add/Remove ATK_STATE_SENSITIVE according to cells' state.
    
    Bug #569042.
Comment 8 Li Yuan 2010-03-05 06:52:01 UTC
Review of attachment 127186 [details] [review]:

committed