After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 568887 - don't rely on GtkAction implementation details
don't rely on GtkAction implementation details
Status: RESOLVED OBSOLETE
Product: gnome-media
Classification: Deprecated
Component: Gnome-Sound-Recorder
unspecified
Other Linux
: Normal major
: ---
Assigned To: gnome media maintainers
gnome media maintainers
Depends on:
Blocks: 568886
 
 
Reported: 2009-01-23 17:50 UTC by Christian Persch
Modified: 2015-01-19 11:33 UTC
See Also:
GNOME target: ---
GNOME version: ---



Description Christian Persch 2009-01-23 17:50:54 UTC
./grecord/src/gsr-window.c:	action = g_object_get_data (G_OBJECT (proxy),  "gtk-action");

+++ This bug was initially created as a clone of Bug #568886 +++

From epiphany bug 568848:

While testing some GtkAction changes in GTK+ trunk, I've found that epiphany
uses
g_object_get_data (widget, "gtk-action") to get at the action associated with a
widget in some places. 

Please don't do that. We consider that undocumented object data an
implementation detail, and it will go away at some point. Instead, use the
documented api  for this: gtk_widget_get_action.

This bugs tracks this problem in the affected modules.
Comment 1 Pablo Castellano (IRC: pablog) 2009-12-17 03:19:15 UTC
Just for the record:

1) It's still present in latest git version.

$ git grep -n gtk-action
grecord/src/gsr-window.c:2165:  action = g_object_get_data (G_OBJECT (proxy),  "gtk-action");


2) gtk_widget_get_action is deprecated.

From documentation:
Warning

gtk_widget_get_action has been deprecated since version 2.16 and should not be used in newly-written code. Use gtk_activatable_get_related_action() instead.
Comment 2 Bastien Nocera 2015-01-19 11:33:36 UTC
gnome-media has been obsolete since the release of GNOME 3, nearly 4 years ago. Furthermore, the gnome-sound-recorder program in gnome-media has been replaced by the stand-alone, rewritten, gnome-sound-recorder program which has a different interface.

The new program should not be affected by the bugs you filed, however, please make sure to file new bugs against the gnome-sound-recorder product.