After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 568702 - gtkdoc-mkhtml no longer works when symlinked
gtkdoc-mkhtml no longer works when symlinked
Status: RESOLVED FIXED
Product: gtk-doc
Classification: Platform
Component: general
1.11
Other Linux
: Normal normal
: 1.12
Assigned To: gtk-doc maintainers
gtk-doc maintainers
Depends on:
Blocks:
 
 
Reported: 2009-01-22 15:01 UTC by Yeti
Modified: 2009-01-23 08:04 UTC
See Also:
GNOME target: ---
GNOME version: ---


Attachments
proposed patch (1.14 KB, patch)
2009-01-22 15:03 UTC, Yeti
committed Details | Review

Description Yeti 2009-01-22 15:01:49 UTC
gtkdoc-mkhtml started to employ the following test to check whether it was
run installed:

# FIXME: this is a hack to detect uninstalled
if test "x$0" = "x@prefix@/bin/gtkdoc-mkhtml" ; then

Obviously, it breaks when you make a symlink to gtkdoc-html and run it under
this name.

AFAIK running uninstalled is necessary only for `make check' within gtk-doc
itself, so I suggest to remove this hack and add --uninstalled option instead
(patch attached).

This option can be then added to MKHTML_OPTIONS where needed (patch not
attached).
Comment 1 Yeti 2009-01-22 15:03:02 UTC
Created attachment 126999 [details] [review]
proposed patch
Comment 2 Stefan Sauer (gstreamer, gtkdoc dev) 2009-01-23 08:04:07 UTC
For the srcdir!=builddir, we could run gtkdoc-mkhtml in case of the tests as
MAKE_SCRDIR=$(abs_srcdir) MAKE_BUILDDIR=$(abs_builddir) gtkdoc-mkhtml ...


2009-01-23  Stefan Kost  <ensonic@users.sf.net>

	patch by: David Nečas <yeti@physics.muni.cz>

	* gtkdoc-mkhtml.in:
	* gtkdoc-mkman.in:
	* tests/gtk-doc.make:
	* tests/gtk-doc.notmpl.make:
	  Less quirky way of knowing that we run uninstalled, which is only
	  needed for the tests anyway. In addition to the patch, make same
	  changes in mkman, add a shift to arg parsing to not loop and change
	  the makefiles for the tests. Fixes #568702.