After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 568229 - library needs libtool versioning
library needs libtool versioning
Status: RESOLVED FIXED
Product: evince
Classification: Core
Component: general
unspecified
Other Linux
: Normal major
: ---
Assigned To: Evince Maintainers
Evince Maintainers
Depends on:
Blocks:
 
 
Reported: 2009-01-18 22:11 UTC by Christian Persch
Modified: 2009-01-21 16:59 UTC
See Also:
GNOME target: ---
GNOME version: ---


Attachments
[PATCH] Bug 568229 – library needs libtool versioning (4.10 KB, patch)
2009-01-18 22:34 UTC, Christian Persch
none Details | Review
[PATCH] Bug 568229 – library needs libtool versioning (4.78 KB, patch)
2009-01-20 18:36 UTC, Christian Persch
accepted-commit_now Details | Review

Description Christian Persch 2009-01-18 22:11:34 UTC
The backend and view libraries are installed into $(libdir), but have they lack libtool versioning.
Comment 1 Christian Persch 2009-01-18 22:34:09 UTC
Created attachment 126725 [details] [review]
[PATCH] Bug 568229 – library needs libtool versioning

Also rename the versioning symbols in ev-version.h to be the same order
as the ones from glib and gtk etc instead of inversed.
---
 configure.ac                |   43 +++++++++++++++++++++++++++++++++----------
 libdocument/Makefile.am     |    5 +++++
 libdocument/ev-version.h.in |   12 ++++++------
 libview/Makefile.am         |    5 +++++
 4 files changed, 49 insertions(+), 16 deletions(-)
Comment 2 Carlos Garcia Campos 2009-01-19 09:39:02 UTC
hmm, I think we should have different version numbers for evince and the libraries. If a new release has only chages in the evince shell we don't want to change the API version. 
Comment 3 Christian Persch 2009-01-20 18:36:59 UTC
Created attachment 126855 [details] [review]
[PATCH] Bug 568229 – library needs libtool versioning

 configure.ac            |   34 +++++++++++++++++++++++++++++++++-
 libdocument/Makefile.am |    7 ++++++-
 libview/Makefile.am     |   15 ++++++++++-----
 3 files changed, 49 insertions(+), 7 deletions(-)
Comment 4 Carlos Garcia Campos 2009-01-21 09:23:34 UTC
Please commit. Thanks. 
Comment 5 Christian Persch 2009-01-21 16:59:43 UTC
Committed.