GNOME Bugzilla – Bug 568209
yelp: patch to display images in Info docs
Last modified: 2018-05-22 12:52:22 UTC
Please describe the problem: Yelp does not parse and display images in Info docs, rather it mangles the cookie and displays the raw [image tag in text. Steps to reproduce: With yelp, visit an Info manual with images example: http://lilypond.org/~janneke/software/info-image/info-image-1.tar.gz lily docs: http://lilypond.org/download/binaries/documentation/lilypond-2.12.1-2.documentation.tar.bz2 Actual results: Yelp does not display the image, but displays the raw [image tag in text, eg: [image src="lilypond/f4/lily-4221a4ab.png" alt="[image of music]" text="[image of music]" ] Expected results: View the image inline. Does this happen every time? Yes. Other information: I'm attaching a patch against yelp HEAD http://lilypond.org/~janneke/software/info-image/yelp-info-image.diff
Created attachment 126714 [details] [review] yelp: display images in Info docs.
Created attachment 126715 [details] LilyPond's Absolute octave entry page with yelp-r3214
Created attachment 126716 [details] LilyPond's Absolute octave entry page with yelp-info-image patch
Many thanks for the patch. I've now committed this to HEAD (rd0cd51f252fd) with a minor modification (to process images on pages with menus in them). This'll be in yelp 2.28 Marking as fixed. 2009-04-30 Don Scorgie <dscorgie@src.gnome.org> * src/yelp-info-parser.c: * stylesheets/info2html: Add support for displaying images in info files Bug #568209 - patch by Jan Nieuwenhuizen
Thanks for applying! I had a followup patch laying around that greatly simplifies the "parsing" of `* Notes:' of info_process_text_notes () by taking advantage of regexps and handling images and * Notes: alongside eachother. I'm attaching an up to date version of the patch.
Created attachment 134107 [details] [review] simplify parsing of info * Notes:, merge with images.
Thanks for the new patch. Reopening so I don't forget about it. I'll do a full review and get it committed soon.
this doesn't seem to work with today's yelp. I see [image of music] in yelps rendering of that 'absolute pitches' page
-- GitLab Migration Automatic Message -- This bug has been migrated to GNOME's GitLab instance and has been closed from further activity. You can subscribe and participate further through the new bug through this link to our GitLab instance: https://gitlab.gnome.org/GNOME/yelp/issues/38.