GNOME Bugzilla – Bug 568176
migration dialog is ugly
Last modified: 2009-02-04 22:36:13 UTC
Has seen in the evolution 2.24 migration to db, the migration dialog is kinda ugly. I finally gave myself some time to write a patch for it.
Created attachment 126688 [details] reworked-migration-dialog.png this is how it will look with my patch. Notable changes are that there is an information icon and it's a bit closer to the look of the copy dialog of nautilus.
Created attachment 126689 [details] [review] evolution-r36946-migration-dialog.patch I've worked on revision 36946 but it should still apply to head. A few things that might be wanted are : * gtk_window_set_deletable (window, false); to hide close window button * remove : at the end of the migrating folder message because there is nothing besides the progress bar behind it so it doesn't make sense imho.
(In reply to comment #2) > A few things that might be wanted are : > * gtk_window_set_deletable (window, false); to hide close window button > * remove : at the end of the migrating folder message because there is nothing > besides the progress bar behind it so it doesn't make sense imho. That and change the header from "Migration" to "Migrating Folders". Looks great otherwise!
well the title is linked to the genericity of the dialog construction. Want an additional parameter to set the title ?
Yeah, I guess add another parameter. Maybe have it default to "Migration" if the parameter is NULL.
Created attachment 126791 [details] [review] evolution-r36946-migration-dialog.patch here you go, updated to have a title parameter.
Hmm, actually I was talking about the big bold text IN the window, not the window title. In fact dialogs such as this probably shouldn't have a window title at all. Sorry if I was unclear. But you're on the right track.
Created attachment 126798 [details] [review] evolution-r36946-migration-dialog.patch hopefully last try :)
Well, you forgot to supply a custom title in migrate_to_db(). I still think "Migrating Folders" reads better than "Migration". Everything else looks good.
I didn't wanted to change any strings because of string freeze. Haven't checked the calendar though.
We're just in String Change Annoucement Period. String Freeze isn't until mid-February.
commited and string change announced. Thanks for reviewing this bug. Closing.