After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 568176 - migration dialog is ugly
migration dialog is ugly
Status: RESOLVED FIXED
Product: evolution
Classification: Applications
Component: general
2.24.x (obsolete)
Other Linux
: Normal enhancement
: ---
Assigned To: Evolution Shell Maintainers Team
Evolution QA team
Depends on:
Blocks:
 
 
Reported: 2009-01-18 13:36 UTC by Gilles Dartiguelongue
Modified: 2009-02-04 22:36 UTC
See Also:
GNOME target: ---
GNOME version: 2.23/2.24


Attachments
reworked-migration-dialog.png (20.87 KB, image/png)
2009-01-18 13:37 UTC, Gilles Dartiguelongue
  Details
evolution-r36946-migration-dialog.patch (3.31 KB, patch)
2009-01-18 13:39 UTC, Gilles Dartiguelongue
reviewed Details | Review
evolution-r36946-migration-dialog.patch (4.41 KB, patch)
2009-01-19 20:41 UTC, Gilles Dartiguelongue
reviewed Details | Review
evolution-r36946-migration-dialog.patch (4.91 KB, patch)
2009-01-19 22:26 UTC, Gilles Dartiguelongue
committed Details | Review

Description Gilles Dartiguelongue 2009-01-18 13:36:43 UTC
Has seen in the evolution 2.24 migration to db, the migration dialog is kinda ugly. I finally gave myself some time to write a patch for it.
Comment 1 Gilles Dartiguelongue 2009-01-18 13:37:56 UTC
Created attachment 126688 [details]
reworked-migration-dialog.png

this is how it will look with my patch. Notable changes are that there is an information icon and it's a bit closer to the look of the copy dialog of nautilus.
Comment 2 Gilles Dartiguelongue 2009-01-18 13:39:58 UTC
Created attachment 126689 [details] [review]
evolution-r36946-migration-dialog.patch

I've worked on revision 36946 but it should still apply to head.

A few things that might be wanted are :
 * gtk_window_set_deletable (window, false); to hide close window button
 * remove : at the end of the migrating folder message because there is nothing besides the progress bar behind it so it doesn't make sense imho.
Comment 3 Matthew Barnes 2009-01-18 15:41:51 UTC
(In reply to comment #2)
> A few things that might be wanted are :
>  * gtk_window_set_deletable (window, false); to hide close window button
>  * remove : at the end of the migrating folder message because there is nothing
> besides the progress bar behind it so it doesn't make sense imho.

That and change the header from "Migration" to "Migrating Folders".
Looks great otherwise!
Comment 4 Gilles Dartiguelongue 2009-01-19 09:35:59 UTC
well the title is linked to the genericity of the dialog construction. Want an additional parameter to set the title ?
Comment 5 Matthew Barnes 2009-01-19 13:19:48 UTC
Yeah, I guess add another parameter.  Maybe have it default to "Migration" if the parameter is NULL.
Comment 6 Gilles Dartiguelongue 2009-01-19 20:41:19 UTC
Created attachment 126791 [details] [review]
evolution-r36946-migration-dialog.patch

here you go, updated to have a title parameter.
Comment 7 Matthew Barnes 2009-01-19 20:48:20 UTC
Hmm, actually I was talking about the big bold text IN the window, not the window title.  In fact dialogs such as this probably shouldn't have a window title at all.

Sorry if I was unclear.  But you're on the right track.
Comment 8 Gilles Dartiguelongue 2009-01-19 22:26:53 UTC
Created attachment 126798 [details] [review]
evolution-r36946-migration-dialog.patch

hopefully last try :)
Comment 9 Matthew Barnes 2009-01-19 22:59:16 UTC
Well, you forgot to supply a custom title in migrate_to_db().  I still think "Migrating Folders" reads better than "Migration".  Everything else looks good.
Comment 10 Gilles Dartiguelongue 2009-01-19 23:58:07 UTC
I didn't wanted to change any strings because of string freeze. Haven't checked the calendar though.
Comment 11 Matthew Barnes 2009-01-20 00:42:28 UTC
We're just in String Change Annoucement Period.

String Freeze isn't until mid-February.
Comment 12 Gilles Dartiguelongue 2009-02-04 22:36:13 UTC
commited and string change announced. Thanks for reviewing this bug. Closing.