GNOME Bugzilla – Bug 567984
Structural navigation needs to consider text within the document frame
Last modified: 2009-01-21 22:45:43 UTC
Please describe the problem: Dear developers! When trying navigating heading with the structural navigating commands and press after the navigation one or more left arrow and after this pressing heading structural navigation commands (for example h jump to next heading), Orca jumping the first heading not a next heading. I seeing this problem for example with www.index.hu/vakbarat webpage. Jon confirm this problem with bug561660 bugreport comment. Attila Steps to reproduce: 1. Open for example with www.index.hu/vakbarat webpage. 2. Try navigate headings for example with h key, and after some navigation press down arrow (one or two down arrow). 3. Press again the h key. If you like, orca jumping a first heading, not a next heading. Actual results: Expected results: Does this happen every time? Yes. Other information:
Confirmed on OpenSolaris 20081.11 with Mozilla/5.0 (X11; U; SunOS i86pc; en-US; rv:1.9.0.4) Gecko/2008111710 Firefox/3.0.4. Very strange since this seems like a very simple web page.
Seems to be related to the collection interface. If I set orca.settings.useCollection to False, the problem goes away. Assigning this one to myself. Stay tuned.
Created attachment 126672 [details] [review] revision 1 (plus a new regression test) This solves the problem for me. I've also created a new regression test based upon this issue. Please test. Thanks!
Thanks Joanmarie, I will be testing the patch monday afternoon. Attila
Joanmarie, testing the patch. The h navigation key and heading navigation numbers work, But the Shift+h key and shift+heading navigation numbers (1-6) is not work good. If would like, try this steps: 1. Launch Firefox, and open www.index.hu/vakbarat webpage. 2. Navigate any heading, and press one or more down arrow key. 3. Press shift+h or shift+heading navigation numbers, the structural navigation jumps bottom of the webpage, and jumps the last heading, not previous heading. If need, I attaching debug.out file. Attila
Thanks for testing Attila! Confirmed. :-( I've also confirmed that the issue you raise in comment #5 occurs without the patch and even when orca.settings.useCollection is set to False. (i.e. it's a different issue). Therefore I've committed the current patch to trunk as a "partial fix" so that it gets included for the 2.25.5 release. I'll see what's up with navigating by previous object/heading.
Created attachment 126898 [details] [review] additional fix Patch plus updated regression test. Pylinted and regression tested for all the structural-navigation-related Firefox tests for both FF 3.0.5 and 3.1b2. Please test. (Given that this patch is limited to structural_navigation.py, the full firefox suite of tests should not show any regressions, but I am extremely paranoid so I'll run those this evening to be sure.) :-)
The patch has been fully regression tested using the Firefox suite for 3.0.5 and 3.1b2 in OpenSolaris. Given that, and the pylinting, and the fact that it's limited to structural navigation I've gone ahead and committed the patch to trunk. Attila, as a result, you don't need a patch to test the changes; just the latest trunk. Thanks for all your help!! Moving to pending.
The simplicity and safeness of the patch, along with the good impact it has, seems to make this a candidate for gnome-2-24. Thoughts?
Agreed. Both patches have been committed to the gnome-2-24 branch. Closing as FIXED.