GNOME Bugzilla – Bug 567765
Cleanups for -DG_DISABLE_DEPRECATED and friends
Last modified: 2009-08-08 14:42:31 UTC
Created attachment 126430 [details] [review]
patch for deprecated api
Ran "patch -p0 < libgnomecanvas-cleanups.patch" and Kjartan's patch applies cleanly.
Removing deprecated stuff requires more work than just this patch though (e.g. GtkType was the first issue I ran into when compiling with -DG_DISABLE_DEPRECATED -DGDK_PIXBUF_DISABLE_DEPRECATED -DGDK_DISABLE_DEPRECATED -DGTK_DISABLE_DEPRECATED)
Evolution will continue to rely on libgnomecanvas whether it's deprecated or not, so tagging this as part of our cleanup effort.
Patch looks pretty straight-forward. Don't know who's responsible for signing off on this, but I'd say as long as everything builds okay it can go in.
Committed Kjartan's patch as b7b5fc64b1699aac5401e8217131d0c431dd5abf.
I recompiled and checked again that there were no newly introduced warnings - the one existing warning has been also fixed by Kjartan's patch.
Keeping the bug opened as there is more work to do.
Sidenote: e.g. libgnomecanvas/gnome-canvas-rich-text.c uses internal gtk+ API.
Ahem... From the last patch,
- gobject's g_value_take_string() requires 2.4
- gobject's g_object_ref_sink () requires 2.10
- gdk's gdk_draw_pixbuf () requires 2.2
Hence retro-actively branched libgnomecanvas for gnome-2-26 and bumped requirements for GTK+ to 2.2.0 and Glib to 2.10.0 in http://git.gnome.org/cgit/libgnomecanvas/commit/?id=7b67b2c3bfe666301117a8d3ee9f1c2b57c30b3e .
jhbuilt a fresh libgnomecanvas with
module_makeargs['libgnomecanvas'] = makeargs + 'CFLAGS+="-DG_DISABLE_DEPRECATED -DGDK_PIXBUF_DISABLE_DEPRECATED -DGDK_DISABLE_DEPRECATED -DGTK_DISABLE_DEPRECATED"'
Closing as FIXED.