After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 567765 - Cleanups for -DG_DISABLE_DEPRECATED and friends
Cleanups for -DG_DISABLE_DEPRECATED and friends
Product: libgnomecanvas
Classification: Deprecated
Component: core
Other Linux
: Normal normal
: ---
Assigned To: libgnomecanvas maintainers
libgnomecanvas maintainers
Depends on:
Reported: 2009-01-14 17:16 UTC by Kjartan Maraas
Modified: 2009-08-08 14:42 UTC
See Also:
GNOME target: ---
GNOME version: ---

patch for deprecated api (15.39 KB, patch)
2009-01-14 17:16 UTC, Kjartan Maraas
committed Details | Review

Description Kjartan Maraas 2009-01-14 17:16:13 UTC
Patch attached.
Comment 1 Kjartan Maraas 2009-01-14 17:16:42 UTC
Created attachment 126430 [details] [review]
patch for deprecated api
Comment 2 André Klapper 2009-07-30 15:52:18 UTC
Ran "patch -p0 < libgnomecanvas-cleanups.patch" and Kjartan's patch applies cleanly.

Removing deprecated stuff requires more work than just this patch though (e.g. GtkType was the first issue I ran into when compiling with -DG_DISABLE_DEPRECATED -DGDK_PIXBUF_DISABLE_DEPRECATED -DGDK_DISABLE_DEPRECATED -DGTK_DISABLE_DEPRECATED)
Comment 3 Matthew Barnes 2009-07-30 16:06:32 UTC
Evolution will continue to rely on libgnomecanvas whether it's deprecated or not, so tagging this as part of our cleanup effort.
Comment 4 Matthew Barnes 2009-07-30 16:10:54 UTC
Patch looks pretty straight-forward.  Don't know who's responsible for signing off on this, but I'd say as long as everything builds okay it can go in.
Comment 5 André Klapper 2009-08-08 13:45:06 UTC
Committed Kjartan's patch as b7b5fc64b1699aac5401e8217131d0c431dd5abf.
I recompiled and checked again that there were no newly introduced warnings - the one existing warning has been also fixed by Kjartan's patch.

Keeping the bug opened as there is more work to do.

Sidenote: e.g. libgnomecanvas/gnome-canvas-rich-text.c uses internal gtk+ API.
Comment 6 André Klapper 2009-08-08 14:25:22 UTC
Ahem... From the last patch,
- gobject's g_value_take_string() requires 2.4
- gobject's g_object_ref_sink () requires 2.10
- gdk's gdk_draw_pixbuf () requires 2.2

Hence retro-actively branched libgnomecanvas for gnome-2-26 and bumped requirements for GTK+ to 2.2.0 and Glib to 2.10.0 in .
Comment 7 André Klapper 2009-08-08 14:42:31 UTC
jhbuilt a fresh libgnomecanvas with

Worked fine.
Closing as FIXED.