After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 567717 - SHAMROCK_FIND_PROGRAM_OR_BAIL doesn't bail
SHAMROCK_FIND_PROGRAM_OR_BAIL doesn't bail
Status: RESOLVED DUPLICATE of bug 562185
Product: banshee
Classification: Other
Component: general
git master
Other All
: Normal normal
: 1.x
Assigned To: Banshee Maintainers
Banshee Maintainers
Depends on:
Blocks:
 
 
Reported: 2009-01-14 07:34 UTC by Christopher Halse Rogers
Modified: 2009-01-14 15:30 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
Patch to make the macro bail when appropriate (382 bytes, patch)
2009-01-14 07:35 UTC, Christopher Halse Rogers 		none Details | Review

Description Christopher Halse Rogers 2009-01-14 07:34:44 UTC 
Please describe the problem:
The SHAMROCK_FIND_PROGRAM_OR_BAIL m4 macro doesn't do what it says on the box :).

In particular, it's test for bailing is if $1 = "no", but $1 is always the variable name to fill, so unless you're looking for the 'no' binary, it always succeeds

Steps to reproduce:


Actual results:


Expected results:


Does this happen every time?


Other information:
Comment 1 Christopher Halse Rogers 2009-01-14 07:35:28 UTC 
Created attachment 126408 [details] [review]
Patch to make the macro bail when appropriate
Comment 2 Gabriel Burt 2009-01-14 15:30:25 UTC 
Thanks for the bug report. This particular bug has already been reported into our bug tracking system, but please feel free to report any further bugs you find.


*** This bug has been marked as a duplicate of 562185 ***