After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 567585 - gstmpegtsdemux pushing newsegments in bytes as well as time format
gstmpegtsdemux pushing newsegments in bytes as well as time format
Status: RESOLVED FIXED
Product: GStreamer
Classification: Platform
Component: gst-plugins-bad
git master
Other All
: Normal normal
: 0.10.12
Assigned To: GStreamer Maintainers
GStreamer Maintainers
Depends on:
Blocks:
 
 
Reported: 2009-01-13 11:57 UTC by kapil
Modified: 2011-05-19 17:19 UTC
See Also:
GNOME target: ---
GNOME version: 2.23/2.24

Attachments
proposed patch (610 bytes, patch)
2009-01-13 12:00 UTC, kapil 		needs-work Details | Review

Description kapil 2009-01-13 11:57:35 UTC 
Please describe the problem:
NewSegment event is just relayed as it is without being worked atall. Since newsegment is send properly through gst_fluts_demux_send_new_segment, not sure if there is any point in forwarding the GST_EVENT_NEWSEGMENT event in the gst_fluts_demux_sink_event.

Steps to reproduce:
1. 
2. 
3. 


Actual results:


Expected results:


Does this happen every time?


Other information:
Comment 1 kapil 2009-01-13 12:00:02 UTC 
Created attachment 126345 [details] [review]
proposed patch

Proposed patch, that just consumes the newsegment event without pushing it to downstream element.
Comment 2 Edward Hervey 2009-01-16 01:47:00 UTC 
What if an upstream element sends a newsegment in GST_FORMAT_TIME ? You're not checking that the incoming newsegment event is in an invalid format.
Comment 3 Sebastian Dröge (slomo) 2011-05-19 17:19:25 UTC 
This was fixed a long time ago:


commit ff7b54e7da95a401665f8d7ae922155a32edac91
Author: Zaheer Merali <zaheerabbas@merali.org>
Date:   Fri May 8 18:24:28 2009 +0100

    mpegtsdemux: Add initial naive seeking support and fix duration query.
    
    Sync from gst-fluendo-mpegdemux and have seeking/duration query
    improvements in. No support however for wrapped around pcrs etc. but a
    start nonetheless.
    Also fix indentation issues.