After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 567575 - Compiler warning in xsltInternals.h
Compiler warning in xsltInternals.h
Status: RESOLVED FIXED
Product: libxslt
Classification: Platform
Component: general
1.1.17
Other All
: Normal minor
: ---
Assigned To: Daniel Veillard
libxml QA maintainers
Depends on:
Blocks:
 
 
Reported: 2009-01-13 09:21 UTC by Trevor Keating
Modified: 2009-01-13 11:54 UTC
See Also:
GNOME target: ---
GNOME version: ---



Description Trevor Keating 2009-01-13 09:21:22 UTC
Please describe the problem:
typedef enum {
    XSLT_FUNC_COPY=1,
    XSLT_FUNC_SORT,
    XSLT_FUNC_TEXT,
    XSLT_FUNC_ELEMENT,
    XSLT_FUNC_ATTRIBUTE,
    XSLT_FUNC_COMMENT,
    XSLT_FUNC_PI,
    XSLT_FUNC_COPYOF,
    XSLT_FUNC_VALUEOF,
    XSLT_FUNC_NUMBER,
    XSLT_FUNC_APPLYIMPORTS,
    XSLT_FUNC_CALLTEMPLATE,
    XSLT_FUNC_APPLYTEMPLATES,
    XSLT_FUNC_CHOOSE,
    XSLT_FUNC_IF,
    XSLT_FUNC_FOREACH,
    XSLT_FUNC_DOCUMENT,
    XSLT_FUNC_WITHPARAM,
    XSLT_FUNC_PARAM,
    XSLT_FUNC_VARIABLE,
    XSLT_FUNC_WHEN,
    XSLT_FUNC_EXTENSION,
#ifdef XSLT_REFACTORED
    XSLT_FUNC_OTHERWISE,
    XSLT_FUNC_FALLBACK,
    XSLT_FUNC_MESSAGE,
    XSLT_FUNC_INCLUDE,
    XSLT_FUNC_ATTRSET,
    XSLT_FUNC_LITERAL_RESULT_ELEMENT,
    XSLT_FUNC_UNKOWN_FORWARDS_COMPAT,
#endif
} xsltStyleType;
is an incorrect enum specification.  It should not have a trailing ',' after the last enum.  This generates a compiler warning msg.

Steps to reproduce:
1. Compile a .C which includes xsltInternals.h
2. 
3. 


Actual results:
A compiler warning is generated.

Expected results:
eh .... no warnings or errors.

Does this happen every time?
Y

Other information:
Comment 1 William M. Brack 2009-01-13 11:47:55 UTC
You, and/or your compiler, are certainly correct that the last comma doesn't belong in that enumeration declaration. But.....

I would respectfully point out that, on August 4, 2006, a correction was made to the SVN code for that line, and the corrected line has appeared in all releases since that date.  Might you possibly consider upgrading your libxml2/libxslt software to a somewhat more current version?
Comment 2 Trevor Keating 2009-01-13 11:54:35 UTC
I would absolutely consider this.  :-^)

Thanks for your time.