After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 567568 - evolution custom email header is not recognized with multi-byte
evolution custom email header is not recognized with multi-byte
Status: RESOLVED FIXED
Product: evolution
Classification: Applications
Component: Plugins
unspecified
Other opensolaris
: Normal normal
: ---
Assigned To: evolution-plugin-maintainers
Evolution QA team
Depends on:
Blocks:
 
 
Reported: 2009-01-13 07:53 UTC by Takao Fujiwara
Modified: 2009-02-03 01:40 UTC
See Also:
GNOME target: ---
GNOME version: ---


Attachments
Patch for plugins/email-custom-header/apps_evolution_email_custom_header.schemas.in and plugins/email-custom-header/email-custom-header.c (3.41 KB, patch)
2009-01-13 07:55 UTC, Takao Fujiwara
none Details | Review

Description Takao Fujiwara 2009-01-13 07:53:09 UTC
evolution custom email header is not recognized with multi-byte.
Recently 567129 is fixed however I'd like to enhance the fix.

To reproduce:
1. Localize the schemas default value "[Security=Personal;Unclassified;Protected;InConfidence;Secret;Topsecret]" in apps_evolution_email_custom_header.schemas.in with .po files.
2. Invoke evolution
3. Choose [File] -> [New] -> [Mail Message].
4. Choose [Insert] -> [Custom Header].

Then localized "Security:" is shown.

5. Click OK button and close the dialog.
6. Choose [File] -> [Send]

And receive the email and save it as a file.

The "Security:" header line is not shown correctly in the actual email file because the multi-byte is not recognized.

I'm attaching the patch.
Comment 1 Takao Fujiwara 2009-01-13 07:55:29 UTC
Created attachment 126334 [details] [review]
Patch for plugins/email-custom-header/apps_evolution_email_custom_header.schemas.in and plugins/email-custom-header/email-custom-header.c

I'd like to localize the GUI only.
Comment 2 Srinivasa Ragavan 2009-01-29 05:26:04 UTC
Looks fine to me. Just commit to trunk. You may have to announce to gnome-doc-list and gnome-i18n list about the changes.
Comment 3 Takao Fujiwara 2009-02-03 01:40:29 UTC
Thanks for your review. I commited the patch.

2009-02-02  Takao Fujiwara  <takao.fujiwara@sun.com>

    Reviewed by Srinivasa Ragavan  <sragavan@novell.com>

    ** Fix for bug #567568

    * apps_evolution_email_custom_header.schemas.in:
    Remove translatable <default> tag.
    * email-custom-header.c (epech_setup_widgets):
    Added gettext for the default custom header.