Created attachment 126192 [details] [review]
0001-drop-libgnomeui-dependency-for-gst-props.patch

Created attachment 126193 [details] [review]
0001-drop-libgnomeui-dependency-for-gst-props.patch

ping - can this get a review please?

+    GtkWidget *dialog;
+    dialog = gtk_dialog_new_with_buttons ("Message",
+                                          NULL, GTK_DIALOG_DESTROY_WITH_PARENT,
+                                          GTK_STOCK_OK, GTK_RESPONSE_NONE, NULL);
+    gtk_container_add (GTK_CONTAINER (gtk_dialog_get_content_area (GTK_DIALOG (dialog))),
+                       gtk_label_new (_("Failure instantiating main window")));
+    g_signal_connect_swapped (dialog, "response", G_CALLBACK (gtk_widget_destroy), dialog);
+    gtk_widget_show_all (dialog);
+

Looks like it'd be simpler to use a GtkMessageDialog here.  It appears you'd also need to do gtk_dialog_run() here, as main() won't enter the mainloop when main_window is NULL.

+  if (! g_option_context_parse (ctx, &argc, &argv, &error)) {
+     g_printerr ("option parsing failed: %s\n", error->message);
+     g_error_free (error);
+     return EXIT_FAILURE;
+  }

I think you'd also need to add the gtk option group to the context here.  It doesn't look like gtk_init would be called otherwise.

Created attachment 132057 [details] [review]
0001-drop-libgnomeui-dependency-for-gst-props.patch

Fixes both issues.  Nice catch on the gtk_init issue!

Looks OK to me now, but I'm not a gnome-media maintainer, so that doesn't mean much..

Can a gnome-media maintainer okay this for me to push please?

Looks fine, though it doesn't actually fix any bugs so it's too late for 2.26. You can commit once all this has been branched.

Saleem, please commit in master branch.

Pushed,  thanks!

Bah, reopening as there are other components which still need to have the dependency removed.

Bug 576273 has my patch to remove libgnome from the media profiles component.

(Updating patch status)

Created attachment 133750 [details] [review]
remove libgnome from grecord

(In reply to comment #14)
> Created an attachment (id=133750) [edit]
> remove libgnome from grecord
> 

Note that it still links against libgnome

Created attachment 133753 [details] [review]
drop libgnome from grecord (+linker)

(In reply to comment #15)
> 
> Note that it still links against libgnome

Okay, tried to fix that here. I thought there were global linker flags in gnome-media. Turned out they are sub-project specific mostly. :-)

commit 9ce374636ffa2d8071feedaac9ceb753a656fb4f
Author: Marc-André Lureau <marcandre.lureau@gmail.com>
Date:   Sat May 2 15:31:50 2009 +0300

    build: remove libgnomeui definitively

    Closes: http://bugzilla.gnome.org/show_bug.cgi?id=567310

commit 955567c04d815c6abd2ee0ecec55f64c629716f7
Author: Felix Riemann <friemann@svn.gnome.org>
Date:   Fri May 1 20:42:22 2009 +0200

    grecord: remove libgnome dependency

    (help http://bugzilla.gnome.org/show_bug.cgi?id=567310)

    Signed-off-by: Marc-André Lureau <marcandre.lureau@gmail.com>

ok, vumeter and cddbslave still depend on gnomeui... changing component/priority/status.

commit d16e4cd15df8f59e3f2cc23afd38a6e4485bd1df
Author: Marc-André Lureau <marcandre.lureau@gmail.com>
Date:   Sat May 2 15:49:29 2009 +0300

    build: oops, cddbslave and vumeter still depends on libgnome/ui

(In reply to comment #18)
> ok, vumeter and cddbslave still depend on gnomeui... changing
> component/priority/status.
> 

Given the recent discussion on d-d-l regarding these submodules conversion to gtkbuilder, can we assume the same for dropping their libgnome dependency? (That it is not worth the work, as they will likely be dropped for 3.0.)

(In reply to comment #19)

> Given the recent discussion on d-d-l regarding these submodules conversion to
> gtkbuilder,...

Err, actually I meant the deprecated GTK symbols. Mixed those two up. :-)

I think so Felix.

commit ce6efc01b852c92db7f783f538b42f82065c11ed
Author: Marc-André Lureau <marcandre.lureau@gmail.com>
Date:   Mon Jul 27 21:56:29 2009 +0300

    Remove vumeter, cddb, and gnome-cd