After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 567251 - Automatic actions backup
Automatic actions backup
Status: RESOLVED FIXED
Product: damned-lies
Classification: Infrastructure
Component: vertimus
unspecified
Other Linux
: High critical
: ---
Assigned To: damned-lies Maintainer(s)
damned-lies Maintainer(s)
Depends on:
Blocks:
 
 
Reported: 2009-01-10 13:55 UTC by Leonardo Ferreira Fontenelle
Modified: 2009-03-06 07:29 UTC
See Also:
GNOME target: ---
GNOME version: ---


Attachments
Backup after committed (1.11 KB, patch)
2009-01-13 13:45 UTC, Claude Paroz
none Details | Review

Description Leonardo Ferreira Fontenelle 2009-01-10 13:55:04 UTC
When a commit is informed, Damned Lies retains that status forever, different from the old Vertimus behaviour. This is especially annoying when we have committed a translation and there are new or changed messages. In this situation, it seems that the only way a translator can reserve the catalog for translation is having the actions backed up first. I'm not sure how much time after a message has been committed the actions history should be cleared, but clearly after new messages are introduced the catalog should be automatically available to be reserved for translation.
Comment 1 Claude Paroz 2009-01-12 11:18:30 UTC
We planned to backup the actions just after the "Inform of submission" has been sent (after stats has been updated).
Inform of submission -> Update statistics for the module -> Backup the actions
Comment 2 Claude Paroz 2009-01-13 13:45:36 UTC
Created attachment 126350 [details] [review]
Backup after committed

Stephane, I've adopted another approach, doing the logic in the form data processing. Hopefully this is less "crado" ;-) What do you think?
About the update_stats, I've supposed this was already done through the real commit.
Comment 3 Stephane Raimbault 2009-01-15 23:08:17 UTC
Committed with a similar but different solution!
Comment 4 Claude Paroz 2009-01-16 13:05:07 UTC
Thanks Stephane. However both 'commit' and 'backup' actions are hard-wired now. We have no use case right now where a 'commit' action doesn't need a backup action, but it might be the case in the future.
Comment 5 Og Maciel 2009-03-05 00:34:39 UTC
I'm seeing this with the Brazilian Portuguese translations. I've manually "closed" most of them but left one [1] so that you can do some forensics/debugging.

Cheers,

Og

[1]  http://l10n.gnome.org/vertimus/totem-pl-parser/HEAD/po/pt_BR
Comment 6 Claude Paroz 2009-03-05 07:10:06 UTC
See, the bug was fixed on mid-January, and your example has a previous date. So please do a "Backup the actions" manually for those remaining before the bug resolution.
Comment 7 Og Maciel 2009-03-05 12:02:34 UTC
My mistake... I thought the fix was retroactive. Thanks Claude.
Comment 8 Leonardo Ferreira Fontenelle 2009-03-05 23:31:01 UTC
Sorry for the unnecessary comment but it take part of the blame for the mis-reopen. I didn't notice too the previously committed translations weren't free.
Comment 9 Claude Paroz 2009-03-06 07:29:41 UTC
No worry, keep cool :-D