After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 567163 - PATCH: fix jitery / cracking sound with 0.10.10 and certain mp3 streams
PATCH: fix jitery / cracking sound with 0.10.10 and certain mp3 streams
Status: RESOLVED OBSOLETE
Product: GStreamer
Classification: Platform
Component: gst-plugins-ugly
0.10.10
Other Linux
: Normal normal
: NONE
Assigned To: GStreamer Maintainers
GStreamer Maintainers
Depends on:
Blocks:
 
 
Reported: 2009-01-09 14:47 UTC by Hans de Goede
Modified: 2010-11-01 17:32 UTC
See Also:
GNOME target: ---
GNOME version: ---


Attachments
log file as requested (50.58 KB, application/x-gzip)
2009-01-10 15:56 UTC, malwkgad
Details

Description Hans de Goede 2009-01-09 14:47:50 UTC
Hi,

I'm the rpmfusion maintainer of gst-plugins-ugly, and some days ago received this bug report: https://bugzilla.rpmfusion.org/show_bug.cgi?id=282

The reporter also reported that going back to our 0.10.9 packages solved this. Our 0.10.9 packages already contained some patches from CVS to fix some issues with 0.10.9, so the most likely cause was this commit:
http://webcvs.freedesktop.org/gstreamer/gst-plugins-ugly/ext/mad/gstmad.c?r1=1.177&r2=1.178

I've build the reporter a 0.10.10 with this commit reversed and that fixed the issue for him. So this commit seems to break mp3 audio in certain scenarios.

I've searched for similar bugs and bug 565458 might be related.
Comment 1 Wim Taymans 2009-01-09 17:52:04 UTC
Can you make a log like this:

 gst-launch -v filesrc location=/path/to/bad/file.mp3 ! mad ! fakesink >log 2>&1

then gzip and attach the resulting log file. That patch was to make sure that an incomming DISCONT flag was also set on the next outgoing buffer, which improved sync in bad files. Maybe the flag is set wrongly in some casesm which we will hopefully see in the log.
Comment 2 Hans de Goede 2009-01-10 13:11:22 UTC
(In reply to comment #1)
> Can you make a log like this:
> 
>  gst-launch -v filesrc location=/path/to/bad/file.mp3 ! mad ! fakesink >log
> 2>&1
> 
> then gzip and attach the resulting log file. That patch was to make sure that
> an incomming DISCONT flag was also set on the next outgoing buffer, which
> improved sync in bad files. Maybe the flag is set wrongly in some casesm which
> we will hopefully see in the log.
> 


Note I do not have access to any trouble causing file. I've asked the reporter of the original issue filed here:
https://bugzilla.rpmfusion.org/show_bug.cgi?id=282

To provide the requested information.
Comment 3 malwkgad 2009-01-10 15:56:12 UTC
Created attachment 126175 [details]
log file as requested

As per your request the log file from the file. Note however that the original file is a video avi with mp3 sound and is clearly bad as often the audio and video are not on the same position. However the newer ugly introduced bad audio output on top of the bad sync between video and audio and was way more irritating. As already denoted by the rpmfusion maintainer the older version was working fine with the audio and the desync between video and audio was compensated very well in every few minutes without disturbing the whole audio stream.
Thanks for your efforts.
Peter
Comment 4 Hans de Goede 2009-01-23 13:50:39 UTC
Clearing needinfo status, as the requested info has been provided.

Comment 5 Edward Hervey 2009-03-06 10:23:03 UTC
This is weird... the caps are constantly changing.
Comment 6 Tim-Philipp Müller 2010-06-22 23:15:16 UTC
Is this still an issue with current versions of things?
Comment 7 Felipe Besoaín Pino 2010-09-30 02:41:26 UTC
Closing this bug report as no further information has been provided. Please feel free to reopen this bug if you can provide the information asked for.
Thanks!
Comment 8 Hans de Goede 2010-10-01 07:26:08 UTC
I've asked the original reporter(in rpmfusion's bugzilla)  to re-test and he can no longer reproduce, so I'm changing the resolution to fixed (for what it is worth).
Comment 9 Tim-Philipp Müller 2010-11-01 17:32:52 UTC
Changing resolution to OBSOLETE since we don't really know what got fixed when where.