GNOME Bugzilla – Bug 567065
Use EmpathyContactSelector when possible
Last modified: 2009-03-23 14:14:52 UTC
use EmpathyContactSelector in the empathy plugin when it's merged and released and stop using the horrible code that's in the plugin at the moment.
Created attachment 126875 [details] [review] Use EmpathyContactSelector The selector's about to be merged, and here's a patch to fix this bug.
Oh, this patch is on top of the fifth patch in bug #567596.
Created attachment 129699 [details] [review] Updated to HEAD I've updated the patch to HEAD. It still depends on bug #567596. Can this be committed after bug #567596 quickly?
Created attachment 130867 [details] [review] more comprehensive patch Here is a more comprehensive patch that not only makes nautilus-sendto build against empathy 2.26, but also lets it run without stumbling over missing symbols from the empathy plugin. Wether it actually works for sending files with Empathy, I don't know.
After a quick look, this patch seems wrong as it's still use the old API (setting FT channel property after its creation instead of passing them to CreateChannel).
While you are on it, it would be nice to fix these 2 warnings: empathy.c: In function 'send_file_cb': empathy.c:195: warning: format not a string literal and no format arguments empathy.c: In function 'send_files': empathy.c:256: warning: format not a string literal and no format arguments
Created attachment 131030 [details] [review] Fixed warnings Updated and fixed warnings.
+1. Please merge it.
2009-03-18 Jonny Lamb <jonny.lamb@collabora.co.uk> * src/plugins/empathy/empathy.c: Fix a couple of warnings and use EmpathyContactSelector. (Closes: #567065)