After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 566614 - bayer2rgb: Make first line configurable
bayer2rgb: Make first line configurable
Status: RESOLVED FIXED
Product: GStreamer
Classification: Platform
Component: gst-plugins-bad
git master
Other Linux
: Normal enhancement
: 0.10.20
Assigned To: GStreamer Maintainers
GStreamer Maintainers
: 571976 (view as bug list)
Depends on:
Blocks:
 
 
Reported: 2009-01-05 12:05 UTC by Luotao Fu
Modified: 2010-07-14 19:32 UTC
See Also:
GNOME target: ---
GNOME version: ---


Attachments
[resend] [patch] bayer2rgb: Make first line configurable (4.24 KB, patch)
2009-01-05 12:11 UTC, Luotao Fu
needs-work Details | Review

Description Luotao Fu 2009-01-05 12:05:55 UTC
Since people can't agree whether the first line of a bayer pattern is a blue/green line or a green/red line, we should make it configurable. This will be as well as an enhancement and a bugfix since we would get funny colors if we start from wrong first line. Because of that this entry is not marked only as enhancement.
Comment 1 Luotao Fu 2009-01-05 12:11:18 UTC
Created attachment 125777 [details] [review]
[resend] [patch] bayer2rgb:  Make first line configurable
Comment 2 Sebastian Dröge (slomo) 2009-01-05 12:25:32 UTC
This should better be added to the video/x-raw-bayer bayer caps IMHO
Comment 3 Wim Taymans 2009-01-05 14:03:00 UTC
To Comment #2, my thoughts as well. But what element will do that? do we need a property on the source?
Comment 4 David Schleef 2009-01-05 23:36:55 UTC
I recall implementing this somewhere as a string in the caps that is one of 'bggr', 'gbrg', 'rggb', or 'grbg'.  Probably a patch I never committed and subsequently distroyed.

My original assumption, which was that only bggr is relevant since manufacturers only make bggr sensors, is incorrect.  Optics (reflection across either axis) and cropping cause other formats to appear.  So I think it is wise to fix all the elements that use bayer to use a format field in the caps.
Comment 5 Sebastian Dröge (slomo) 2009-02-16 14:22:30 UTC
*** Bug 571976 has been marked as a duplicate of this bug. ***
Comment 6 Guennadi Liakhovetski 2010-07-14 15:55:57 UTC
18 months since the original post and the first patch and 17 month since the second patch (from me) (Comment 5) - any progress with a proper fix?
Comment 7 Tim-Philipp Müller 2010-07-14 16:18:48 UTC
> 18 months since the original post and the first patch and 17 month since the
> second patch (from me) (Comment 5) - any progress with a proper fix?

Both of these patches do not implement the desired approach as far as I can tell.

You can help speed things up by implementing the desired approach (see comment 2, comment 3, and comment 4). If you need more information on how to do this, feel free to ask.
Comment 8 David Schleef 2010-07-14 19:04:24 UTC
Have patch.  Will push.
Comment 9 David Schleef 2010-07-14 19:07:53 UTC
Or, already pushed:

commit 90a2cd5cc5761ed9a8491e157bd959e3f06949f5
Author: David Schleef <ds@schleef.org>
Date:   Thu Jun 3 18:14:05 2010 -0700

    bayer2rgb: handle other bayer formats