GNOME Bugzilla – Bug 566614
bayer2rgb: Make first line configurable
Last modified: 2010-07-14 19:32:03 UTC
Since people can't agree whether the first line of a bayer pattern is a blue/green line or a green/red line, we should make it configurable. This will be as well as an enhancement and a bugfix since we would get funny colors if we start from wrong first line. Because of that this entry is not marked only as enhancement.
Created attachment 125777 [details] [review] [resend] [patch] bayer2rgb: Make first line configurable
This should better be added to the video/x-raw-bayer bayer caps IMHO
To Comment #2, my thoughts as well. But what element will do that? do we need a property on the source?
I recall implementing this somewhere as a string in the caps that is one of 'bggr', 'gbrg', 'rggb', or 'grbg'. Probably a patch I never committed and subsequently distroyed. My original assumption, which was that only bggr is relevant since manufacturers only make bggr sensors, is incorrect. Optics (reflection across either axis) and cropping cause other formats to appear. So I think it is wise to fix all the elements that use bayer to use a format field in the caps.
*** Bug 571976 has been marked as a duplicate of this bug. ***
18 months since the original post and the first patch and 17 month since the second patch (from me) (Comment 5) - any progress with a proper fix?
> 18 months since the original post and the first patch and 17 month since the > second patch (from me) (Comment 5) - any progress with a proper fix? Both of these patches do not implement the desired approach as far as I can tell. You can help speed things up by implementing the desired approach (see comment 2, comment 3, and comment 4). If you need more information on how to do this, feel free to ask.
Have patch. Will push.
Or, already pushed: commit 90a2cd5cc5761ed9a8491e157bd959e3f06949f5 Author: David Schleef <ds@schleef.org> Date: Thu Jun 3 18:14:05 2010 -0700 bayer2rgb: handle other bayer formats