GNOME Bugzilla – Bug 566354
Handle server's resource rename on WebDAV PUT response
Last modified: 2012-05-02 10:28:09 UTC
Please describe the problem: According to the GroupDAV spec (see http://www.groupdav.org/draft-hess-groupdav-01.txt, sec. 4. Handling of UIDs and sec. 5.4. Creating Items) any GroupDAV server may return a Location header after a PUT method (when creating a new item, i.e. when the status code is "201 Created") if the server wishes to enforce its own resource naming scheme. (Yes, this probably contradicts to the HTTP/1.1 spec, but we can assume, that many RDBMS based GroupDAV servers will use this). Steps to reproduce: Actual results: Expected results: Does this happen every time? Other information:
Created attachment 125658 [details] [review] Patch to implement handling Location headers after PUT
Can you review the patch Matze?
patch looks also fine. I have a slightly modified version here which handles relative URI with the help of libsoup. I'll commit when my account is enabled.
Hello, anything new on this? Could we, please, get it at least to some near stable release? Thank You!
Matzeb, can you commit yours? Or I could do that for you. Thanks
Any news about this? Thanks
It would be great to have this patch committed.
Created attachment 160515 [details] [review] eds patch for evolution-data-server; Updated patch, with the relative URI support added. I hope I got it right, when the relative uri is returned then it means the returned Location is a path on the server, like the path without host name. If not, then let's see when someone finds.
Created commit 705b186 in eds master (2.31.2+) Created commit 985f39d in eds gnome-2-30 (2.30.2+)
Created attachment 164680 [details] [review] Fix redirect status check in caldav
For me the issue is not yet completely fixed. redirect_handler must also check for Location when status code is 201.
Please open a new bug report, and do not steal already closed one for a new issue in another part of the code. Also, the "201 Created" is not a redirection, thus I do not think it's a good thing to do.
As Petr wrote in comment #0, the correct thing would be to read the Location header and change href of the item in CalDAV, not to process redirection like when was really redirected to other place.
(In reply to comment #12) Ok, I will. I was just finding that this issue was not fixed as the patch proposed fix only some part.
Just for a record, the new bug is bug #623066