After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 566354 - Handle server's resource rename on WebDAV PUT response
Handle server's resource rename on WebDAV PUT response
Status: RESOLVED FIXED
Product: evolution-data-server
Classification: Platform
Component: Contacts
unspecified
Other All
: Normal normal
: ---
Assigned To: evolution-addressbook-maintainers
Evolution QA team
Depends on:
Blocks:
 
 
Reported: 2009-01-02 19:41 UTC by Petr Tomasek
Modified: 2012-05-02 10:28 UTC
See Also:
GNOME target: ---
GNOME version: 2.25/2.26


Attachments
Patch to implement handling Location headers after PUT (1.81 KB, patch)
2009-01-02 19:42 UTC, Petr Tomasek
none Details | Review
eds patch (2.06 KB, patch)
2010-05-07 15:07 UTC, Milan Crha
committed Details | Review
Fix redirect status check in caldav (717 bytes, patch)
2010-06-26 14:45 UTC, Cédric Krier
rejected Details | Review

Description Petr Tomasek 2009-01-02 19:41:17 UTC
Please describe the problem:
According to the GroupDAV spec (see http://www.groupdav.org/draft-hess-groupdav-01.txt, sec. 4. Handling of UIDs and sec. 5.4. Creating Items) any GroupDAV server may return a Location header after a PUT method (when creating a new item, i.e. when the status code is "201 Created") if the server wishes to enforce its own resource naming scheme. (Yes, this probably contradicts to the HTTP/1.1 spec, but we can assume, that many RDBMS based GroupDAV servers will use this).


Steps to reproduce:


Actual results:


Expected results:


Does this happen every time?


Other information:
Comment 1 Petr Tomasek 2009-01-02 19:42:51 UTC
Created attachment 125658 [details] [review]
Patch to implement handling Location headers after PUT
Comment 2 Srinivasa Ragavan 2009-01-08 15:10:48 UTC
Can you review the patch Matze?
Comment 3 MatzeB 2009-01-16 12:20:12 UTC
patch looks also fine. I have a slightly modified version here which handles relative URI with the help of libsoup. I'll commit when my account is enabled.
Comment 4 Petr Tomasek 2009-03-18 13:16:31 UTC
Hello, anything new on this? Could we, please, get it at least to some near stable release?

Thank You!
Comment 5 Srinivasa Ragavan 2009-04-20 07:53:01 UTC
Matzeb, can you commit yours? Or I could do that for you. Thanks
Comment 6 Cédric Krier 2010-01-26 12:47:38 UTC
Any news about this?
Thanks
Comment 7 awilliam 2010-04-26 10:38:44 UTC
It would be great to have this patch committed.
Comment 8 Milan Crha 2010-05-07 15:07:55 UTC
Created attachment 160515 [details] [review]
eds patch

for evolution-data-server;

Updated patch, with the relative URI support added. I hope I got it right, when the relative uri is returned then it means the returned Location is a path on the server, like the path without host name. If not, then let's see when someone finds.
Comment 9 Milan Crha 2010-05-07 15:11:05 UTC
Created commit 705b186 in eds master (2.31.2+)
Created commit 985f39d in eds gnome-2-30 (2.30.2+)
Comment 10 Cédric Krier 2010-06-26 14:45:22 UTC
Created attachment 164680 [details] [review]
Fix redirect status check in caldav
Comment 11 Cédric Krier 2010-06-26 14:46:33 UTC
For me the issue is not yet completely fixed.
redirect_handler must also check for Location when status code is 201.
Comment 12 Milan Crha 2010-06-28 10:11:53 UTC
Please open a new bug report, and do not steal already closed one for a new issue in another part of the code. Also, the "201 Created" is not a redirection, thus I do not think it's a good thing to do.
Comment 13 Milan Crha 2010-06-28 10:13:48 UTC
As Petr wrote in comment #0, the correct thing would be to read the Location header and change href of the item in CalDAV, not to process redirection like when was really redirected to other place.
Comment 14 Cédric Krier 2010-06-28 11:24:30 UTC
(In reply to comment #12)

Ok, I will. I was just finding that this issue was not fixed as the patch proposed fix only some part.
Comment 15 Milan Crha 2012-05-02 10:28:09 UTC
Just for a record, the new bug is bug #623066