After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 566330 - WebDAV backend for addressbook is too strict about content-type.
WebDAV backend for addressbook is too strict about content-type.
Status: RESOLVED FIXED
Product: evolution-data-server
Classification: Platform
Component: Contacts
unspecified
Other All
: Normal normal
: ---
Assigned To: evolution-addressbook-maintainers
Evolution QA team
: 610572 (view as bug list)
Depends on:
Blocks:
 
 
Reported: 2009-01-02 14:49 UTC by Petr Tomasek
Modified: 2011-06-22 08:48 UTC
See Also:
GNOME target: ---
GNOME version: 2.25/2.26


Attachments
Patch which comments out content-type checks for the GET request (777 bytes, patch)
2009-01-02 14:52 UTC, Petr Tomasek
committed Details | Review

Description Petr Tomasek 2009-01-02 14:49:12 UTC
Please describe the problem:
WebDAV backend for addressbook is too strict about content-type. This prevents simple WebDAV stores (without special configuration) from work. E.g. my sample webdav server returned "text/plain; charset=UTF-8" as the content-type for the vcards saved on the server, while the code was checking strictly for "text/x-vcard".

I suggest to disable the checking completely for now (or implement more clever content-type checking, that would allow at least for following content-types: "text/plain", "text/x-vcard", "text/vcard", "text/directory", "text/directory;profile=vCard" and that would handle properly the charset option). The backend parses (and thus checks) the content of the resource anyway, so checking for content-type doesn't really bring anything...


Steps to reproduce:


Actual results:


Expected results:


Does this happen every time?


Other information:
Comment 1 Petr Tomasek 2009-01-02 14:52:58 UTC
Created attachment 125649 [details] [review]
Patch which comments out content-type checks for the GET request

With this patch a simple webdav store (on apache without special configuration) starts to work...
Comment 2 Srinivasa Ragavan 2009-01-08 15:10:15 UTC
I dont think this is a nice idea, but lets check with matze, who is the author of the the backend.
Comment 3 MatzeB 2009-01-16 11:57:47 UTC
I had some reports from other people with similar problems and indeed most mime-type files delivered with linux distros seem to lack entries for vcard files.

I agree that the current Content-Type parser in the code is too naiv. Making the pragmatic choice of disabling it is the best thing to do at the moment :-(
Comment 4 Milan Crha 2010-05-07 14:45:56 UTC
Created commit c771dfd in eds master (2.31.2+)
Created commit 2870c01 in eds gnome-2-30 (2.30.2+)

Pity it took so long.
Comment 5 Milan Crha 2010-05-07 16:34:04 UTC
One problem with that, it tries to create a contact for regular text/html responses, which makes contact empty. I changed this within commit
for bug #617168 in master and in:

Created commit c840dac in eds gnome-2-30 (2.30.2+)
Comment 6 Milan Crha 2011-06-22 08:48:19 UTC
*** Bug 610572 has been marked as a duplicate of this bug. ***