After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 565944 - Missing whitespace when the end of line braille indicator is followed by an image in FF 3.x
Missing whitespace when the end of line braille indicator is followed by an i...
Status: RESOLVED FIXED
Product: orca
Classification: Applications
Component: braille
2.25.x
Other All
: Normal minor
: 2.24.3
Assigned To: Joanmarie Diggs (IRC: joanie)
Orca Maintainers
Depends on:
Blocks: 404403
 
 
Reported: 2008-12-29 15:35 UTC by Joanmarie Diggs (IRC: joanie)
Modified: 2009-01-05 19:15 UTC
See Also:
GNOME target: ---
GNOME version: 2.23/2.24

Attachments
patch (4.05 KB, patch)
2008-12-29 15:43 UTC, Joanmarie Diggs (IRC: joanie) 		committed Details | Review

Description Joanmarie Diggs (IRC: joanie) 2008-12-29 15:35:53 UTC 
Given an entry followed by an image on the same line in FF 3.x, we see this in braille: "$lImage". We should see this: "$l Image".
Comment 1 Joanmarie Diggs (IRC: joanie) 2008-12-29 15:43:17 UTC 
Created attachment 125482 [details] [review]
patch

This patch is extremely minor and just adds the space where it belongs in the Gecko script's updateBraille. It has been pylinted and regression tested for both 3.0.5 and 3.1beta2 in OpenSolaris. It also eliminates a few "BUG?" lines I had marked in our existing tests. Yea! :-)

Already committed to trunk.
Comment 2 Willie Walker 2009-01-05 13:59:17 UTC 
This seems safe and appropriate for gnome-2-24 as well.  Joanie -- if you agree, please check it into gnome-2-24.
Comment 3 Joanmarie Diggs (IRC: joanie) 2009-01-05 19:15:16 UTC 
Done. The regression tests are so different now that I didn't commit the test changes; just the fix. :-)

Readjusting the milestone.